Update Node.js dependencies and fix annoyances (googleforgames#1415)

* Fix health stream not closing properly. Update dependencies * Fix Buffer deprecation warning * Update test for fix
ilkercelikyilmaz · Oct 23, 2020 · 02058e1 · 02058e1
1 parent 9001be8
commit 02058e1
Show file tree

Hide file tree

Showing 6 changed files with 1,007 additions and 757 deletions.
diff --git a/build/build-sdk-images/node/gen.sh b/build/build-sdk-images/node/gen.sh
@@ -25,7 +25,7 @@ googleapis=/go/src/agones.dev/agones/proto/googleapis
 
 cd /go/src/agones.dev/agones
 
-protoc -I ${googleapis} -I ${sdk} --grpc_out=./sdks/nodejs/lib --plugin=protoc-gen-grpc=`which grpc_node_plugin` sdk.proto
+protoc -I ${googleapis} -I ${sdk} --grpc_out=minimum_node_version=12:./sdks/nodejs/lib --plugin=protoc-gen-grpc=`which grpc_node_plugin` sdk.proto
 protoc -I ${googleapis} -I ${sdk} --js_out=import_style=commonjs,binary:./sdks/nodejs/lib sdk.proto ${googleapis}/google/api/annotations.proto ${googleapis}/google/api/http.proto
 
 header ./sdks/nodejs/lib/sdk_pb.js

diff --git a/sdks/nodejs/lib/sdk_grpc_pb.js b/sdks/nodejs/lib/sdk_grpc_pb.js
@@ -24,7 +24,7 @@ function serialize_agones_dev_sdk_Duration(arg) {
   if (!(arg instanceof sdk_pb.Duration)) {
     throw new Error('Expected argument of type agones.dev.sdk.Duration');
   }
-  return new Buffer(arg.serializeBinary());
+  return Buffer.from(arg.serializeBinary());
 }
 
 function deserialize_agones_dev_sdk_Duration(buffer_arg) {
@@ -35,7 +35,7 @@ function serialize_agones_dev_sdk_Empty(arg) {
   if (!(arg instanceof sdk_pb.Empty)) {
     throw new Error('Expected argument of type agones.dev.sdk.Empty');
   }
-  return new Buffer(arg.serializeBinary());
+  return Buffer.from(arg.serializeBinary());
 }
 
 function deserialize_agones_dev_sdk_Empty(buffer_arg) {
@@ -46,7 +46,7 @@ function serialize_agones_dev_sdk_GameServer(arg) {
   if (!(arg instanceof sdk_pb.GameServer)) {
     throw new Error('Expected argument of type agones.dev.sdk.GameServer');
   }
-  return new Buffer(arg.serializeBinary());
+  return Buffer.from(arg.serializeBinary());
 }
 
 function deserialize_agones_dev_sdk_GameServer(buffer_arg) {
@@ -57,7 +57,7 @@ function serialize_agones_dev_sdk_KeyValue(arg) {
   if (!(arg instanceof sdk_pb.KeyValue)) {
     throw new Error('Expected argument of type agones.dev.sdk.KeyValue');
   }
-  return new Buffer(arg.serializeBinary());
+  return Buffer.from(arg.serializeBinary());
 }
 
 function deserialize_agones_dev_sdk_KeyValue(buffer_arg) {