Skip to content

Commit

Permalink
Bump trybuild to 1.0.98, and MSRV to 1.70.0 (#151)
Browse files Browse the repository at this point in the history
This necessitates bumping MSRV to 1.70.0, which is a significant change
from 1.56.0.

1.70.0 was more than a year ago, and seems like a reasonable bump, but
it's a bit unfortunate that we're doing this bump only for a test-only
dependency.

As we're not actually changing any production code here, things are
likely to continue to work with older rust versions, but we will not
continue testing this, and make no promises versions older than 1.70.0
will keep working.
  • Loading branch information
illicitonion authored Jul 29, 2024
1 parent 8686d3e commit 4d25890
Show file tree
Hide file tree
Showing 6 changed files with 107 additions and 52 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/msrv-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: dtolnay/rust-toolchain@v1
with:
profile: minimal
toolchain: 1.56.0
toolchain: 1.70.0
target: thumbv6m-none-eabi
- name: Use MSRV Cargo.lock
run: cp Cargo.lock.msrv Cargo.lock
Expand All @@ -24,10 +24,10 @@ jobs:
with:
command: build
args: --all --locked
toolchain: 1.56.0
toolchain: 1.70.0
- name: Build no-std with MSRV
uses: actions-rs/cargo@v1
with:
command: build
args: --manifest-path=num_enum/Cargo.toml --target thumbv6m-none-eabi --no-default-features --locked
toolchain: 1.56.0
toolchain: 1.70.0
143 changes: 99 additions & 44 deletions Cargo.lock.msrv

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions num_enum/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "num_enum"
version = "0.7.2" # Keep in sync with num_enum_derive, the the dependency on it below.
rust-version = "1.56.0"
rust-version = "1.70.0"
authors = [
"Daniel Wagner-Hall <dawagner@gmail.com>",
"Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>",
Expand Down Expand Up @@ -36,5 +36,5 @@ num_enum_derive = { version = "=0.7.2", path = "../num_enum_derive", default-fea
anyhow = "1.0.14"
paste = "1"
rustversion = "1.0.4"
trybuild = "1.0.49"
trybuild = "1.0.98"
walkdir = "2"
2 changes: 1 addition & 1 deletion num_enum_derive/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "num_enum_derive"
version = "0.7.2" # Keep in sync with num_enum.
rust-version = "1.56.0"
rust-version = "1.70.0"
authors = [
"Daniel Wagner-Hall <dawagner@gmail.com>",
"Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>",
Expand Down
2 changes: 1 addition & 1 deletion serde_example/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ publish = false

[dependencies]
num_enum = { path = "../num_enum", default-features = false }
serde = { version = "1", default_features = false, features = ["derive"] }
serde = { version = "1", default-features = false, features = ["derive"] }
2 changes: 1 addition & 1 deletion stress_tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ publish = false

[dev-dependencies]
num_enum = { path = "../num_enum" }
trybuild = "1.0.31"
trybuild = "1.0.98"

0 comments on commit 4d25890

Please sign in to comment.