Support specifying ranges of alternate values #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests around detecting why things failed and reporting them are failing in ways I completely expected, but which weren't happening locally to me for some reason - will fix up soon! |
For simplicity, we require both ends of the range to be specified an literals. This only works if the `complex-expressions` feature is enabled, as `syn` can't parse ranges without its `full` feature being enabled, which significantly increases compile times. We give a useful error if you attempt to use ranges without this feature being enabled.
Pre-1.0.4 it pulled in syn with the "full" feature, which broke some of our tests for testing when full is disabled, in minimal versions mode.
danielhenrymantilla
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simplicity, we require both ends of the range to be specified an literals.
This only works if the
complex-expressionsfeature is enabled, assyncan't parse ranges without itsfullfeature being enabled, which significantly increases compile times. We give a useful error if you attempt to use ranges without this feature being enabled.Fixes #101