UnsafeFromPrimitive ignores default/alternatives #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is a positive change, but am open to discussion... |
Previously it would fail to derive, but there are valid use-cases for
wanting to perform the unsafe conversion for known "natural" values.
This potentially opens up a bit of confusion around what the behaviours
are when these attributes are present but ignored, but these are also
documented, and if someone is reaching for this unsafe function rather
than using `{,Try}FromPrimitive` or just an `as` cast, presumably
they're paying attention...
illicitonion
force-pushed
the
unsafe-ignores-attr
branch
from
a125c65
to
a151410
Compare
danielhenrymantilla
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
I think that with the added documentation it should be fine, yeah ✅.
- (Although I almost wish the
from_unchecked()function were renamed totransmute_fromat that point, just to be extra clear. Not something I am seriously suggesting, just something that we could keep on the back of our mind before a1.0release, for instance 🙂)
Co-authored-by: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
illicitonion
force-pushed
the
unsafe-ignores-attr
branch
from
444fe13
to
5792a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would fail to derive, but there are valid use-cases for wanting to perform the unsafe conversion for known "natural" values.
This potentially opens up a bit of confusion around what the behaviours are when these attributes are present but ignored, but these are also documented, and if someone is reaching for this unsafe function rather than using
{,Try}FromPrimitiveor just anascast, presumably they're paying attention...Fixes #32