Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proc-macro-crate to 2.0, cargo_toml to 0.16, and MSRV to 1.66.1 #134

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

oeb25
Copy link
Contributor

@oeb25 oeb25 commented Oct 16, 2023

This indirectly bumps toml_edit to v0.20.2.

Personally, this would be useful for reducing the number of versions of toml_edit we are building in our project.

This indirectly bumps toml_edit to 0.20.2
@oeb25
Copy link
Contributor Author

oeb25 commented Oct 16, 2023

I see that proc-macro-crate has rust-version = "1.66.0", while num_enum has rust-version = "1.56.0" which results in the MSRV build failing, as also shown by the CI job.

It's up to you whether or not you want to bump the MSRV. I understand if you want to keep it at 1.56.0!

@oeb25
Copy link
Contributor Author

oeb25 commented Oct 16, 2023

Another bump, if you want to go ahead with this, would be cargo_toml, which is at v0.13.3 while the latest is at v0.16.3 and also depends on toml_edit v0.22.2 indirectly, minimizing the versions of toml depended on by this crate.

@oeb25 oeb25 changed the title Update proc-macro-crate to 2.0 Update proc-macro-crate to 2.0, cargo_toml to 0.16, and MSRV to 1.66.1 Oct 17, 2023
@oeb25
Copy link
Contributor Author

oeb25 commented Oct 25, 2023

Alright! Specifying version ranges for proc-macro-crate and cargo_toml works for the existing Cargo.toml.msrv and Rust 1.56.0. And for the latest Rust version, there's only one version of toml_edit depended upon!

Copy link
Owner

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much!

@illicitonion illicitonion merged commit 0407569 into illicitonion:main Oct 27, 2023
6 checks passed
@illicitonion
Copy link
Owner

This was published as 0.7.1 - thanks for the contribution!

@oeb25
Copy link
Contributor Author

oeb25 commented Oct 27, 2023

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants