-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: VSCode 1.86.0 on Windows is incompatible (blurry text when scrolling) #122
Comments
Hey @rsa16 , i am experiencing the exact same behavior here. I beliecve it has begun when i dettached a vscode window.
|
Same here, began when I updated VS Code today. EDIT: Downgrading to v1.85 fixed it for me, make sure to disable automatic updates before downgrading. |
I'm able to reproduce this as well, probably caused by VSCode updating to Electron 27 |
@illixion Thx man! Any prevision in order to release a fix? |
To also input: Affected Visual Studio Code Version: |
Reproduced on my machine. |
From my tests with the VS Code Edit: oh yeah, I forgot to mention, that with |
When will this be fixed? |
@ShayBox Hey! I downgraded to v1.85 and I noticed that my vibrancy looks nothing compared to what it looked previously, I'm using the same settings and didn't change anything. Any clue why this is? This is my current vibrancy: This was my previous vibrancy: See how much they changed..? |
I couldn't say why it appears different, mine appears the same. You can try adjusting the opacity setting. |
@Xyeut no ETA on a fix since I don't use VSCode on Windows, if anyone else creates a PR then I'll be happy to merge it. In regards to the changed appearance, this is because the default transparency mode has been changed to prepare for VSCode 1.86 deprecating it, you can restore the old behavior by choosing |
@illixion Ah alright, all good! I'll just use 1.85 till then, I changed the "Native method of Vibrancy Effect" to dark, however didn't make any changes. |
Sure, just go to VSCode settings and search for "Vibrancy", or look for it in the sidebar. The setting will be in the Vibrancy category |
@illixion Alright, does this look right? |
Yes |
@illixion Alright, I ended up changing it and I'm still facing the same issue. 😅 It does say when I select dark that it's deprecated |
My bad, forgot that you're on Windows, it's probably the opacity then (it also says that it was modified in the Workspace in the screenshot, might be relevant) |
@illixion wow.. I feel like an idiot, I appreciate you. Thank you for dedicating the time for helping out with this package 😁 |
Fixed for me too, Thanks! You have a place in Heaven. |
Hey @illixion if the users don't care about the miss of the maximizing capability, and you agree, I could send a PR to set the |
Umm... Users probably care about it. |
If it just removes the maximize button it's not a big deal, you can use aero snap or alt snap, but if it disabled resizing entirely it would be a problem. |
It'll be nice if you add a option to select vibrancy impl method. |
How do I uninstall the extension so that css get restored? |
Using the "Disable Vibrancy" action in VSCode will restore everything to the original state, just disabling the extension doesn't run the necessary code to undo the changes |
You have to downgrade to 1.85 for it to work right now, only option. |
@illixion is there an ETA on when it'll be fixed on 1.86? I'm on windows. |
Reproduced on my machine. |
|
Since Electron 27+ prevents DWM from redrawing video frames rendered on opaque windows, the BrowserWindow must be set to frameless & transparent for Mica/Acrylic to work again. According to Electron docs, transparent windows can't be maximized on Windows, they are also not resizable. So, the best solution for now is still to downgrade to Electron 26 (VSCode 1.85), if you wish to continue using VSCode Vibrancy. |
If that's what must be done, I use alt snap to resize and move windows anyway, can this be updated? |
Can this issue be added to the FAQ as a known issue with the downgrading workaround? |
I think the triage tag can be removed for this issue, now that the cause got figured out |
Updated the description with a notice, will look into providing a workaround by making the window non-resizable separately later |
As a workaround you can use the Apc Customize UI++ extension to use acrylic but for aforementioned reasons maximizing will disable the effect until you restart VSCode. While tedious, you can manually resize the window to take up the full width and height of a monitor and it doesn't seem to break. apc-vibrancy.mp4 |
@duckies Sorry for the annoying, Massive thanks in advance <3 |
This is Windows, yes. The settings are mostly trial and error or personal preference. "apc.electron": {
"frame": false,
"backgroundColor": "#00000000",
"backgroundMaterial": "acrylic",
"titleBarStyle": "hiddenInset",
"transparent": true,
},
"apc.stylesheet": {
"html,body,.part.titlebar": "background-color:#00000040 !important"
}, You then need either a transparent theme or override your themes settings: // These are not exhaustive, just what I've cobbled together for my use.
"workbench.colorCustomizations": {
"editorGroupHeader.tabsBackground": "#00000000",
"sideBar.background": "#00000000",
"sideBarSectionHeader.background": "#00000000",
"editor.background": "#00000000",
"editorGroup.border": "#00000000",
"editorGroupHeader.tabsBorder": "#00000000",
"peekViewEditor.background": "#00000000",
"peekViewEditorGutter.background": "#00000000",
"panel.background": "#00000000",
"panel.border": "#00000000",
"panelInput.border": "#00000000",
"panelTitle.activeBorder": "#ffffffaa",
"titleBar.border": "#00000000",
"titleBar.inactiveBackground": "#00000000",
"terminal.background": "#00000000",
"statusBar.background": "#00000000",
"activityBar.background": "#00000000",
"activityBar.activeBackground": "#00000030",
"activityBar.border": "#00000000",
"editorGutter.background": "#00000000",
"tab.activeBackground": "#ffffff10",
"tab.activeBorder": "#00000000",
"tab.activeBorderTop": "#00000000",
"tab.border": "#00000000",
"tab.hoverBackground": "#ffffff20",
"tab.hoverBorder": "#00000000",
"tab.inactiveBackground": "#00000000",
"tab.inactiveForeground": "#ffffff80",
"tab.unfocusedActiveBorder": "#00000000",
"tab.unfocusedActiveBorderTop": "#00000000",
"tab.unfocusedHoverBackground": "#ffffff20",
"menu.background": "#161616d0",
"menu.border": "#00000000",
"menu.foreground": "#cccccc",
"menu.separatorBackground": "#00000000",
"sideBar.border": "#00000000",
"statusBar.border": "#00000000"
} |
@duckies Firstly massive thanks for your time and reply, |
If this is broken in VSCode 1.86+ due to:
is there any expectation that this will be updated to support future versions of vscode? I don't want to be stuck using VSCode 1.85 just to support my vibrancy effect :( |
Supposedly it still works if the frame is disabled, which just means you can't resize/minimize/maximize the window using the frame controls, you can still use third-party tools like AltSnap to do that. This is a limitation that also applies to Discord, I don't have a Discord frame but I keep it maximized all the time like VSCode anyway. EDIT: You can also use the custom titlebar instead of native which gives you minimize/maximize buttons, just no resizing because there's no frame edge to grab. |
I've just released v1.1.29 which includes the workaround mentioned by @microhobby (thanks!), from my testing on Windows 11 the window remains resizable but cannot be snapped or maximized, third-party snapping software might still work though. |
how to download altsnap ? |
@sharmakriah13 you can find it right here: https://github.com/RamonUnch/AltSnap/releases |
Is there an existing issue for this?
Current Behavior
An odd text-duplication effect when scrolling.
Expected Behavior
Working transparency and normal behavior, though that is not what I got.
Steps To Reproduce
I'm not sure how to reproduce this problem, but I've tried uninstalling and reinstalling Vibrancy multiple times. I really don't want to reinstall vscode.
Environment
Anything else?
Recording.2024-02-01.132241.mp4
The text was updated successfully, but these errors were encountered: