Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SDK version compatible with .NET Framework 4.5 #19

Closed
maztch opened this issue Nov 14, 2019 · 5 comments
Closed

Provide SDK version compatible with .NET Framework 4.5 #19

maztch opened this issue Nov 14, 2019 · 5 comments

Comments

@maztch
Copy link

maztch commented Nov 14, 2019

After some experimenting, I found that when I add the nuget package (and not trying to compile the project myself), all works like a charm.
However, you have one dependency to a component that requires .NET 4.6. This prevents us from using the component from Windows PowerShell (as this component apparently uses .NET 4 or 4.5).
When I run the same code sample in the cross-platform PowerShell 7, it works perfectly well so I assume it must be related to the dependency (which returns the exception that “response” is NULL).
Being compatible with Windows PowerShell is somewhat important as this is the default scripting environment on Windows and widely used in the industry.

@OlegRa
Copy link
Contributor

OlegRa commented Nov 14, 2019

@maztch I'll check our dependencies list and write you back later about possible solutions for your issue. If it will be possible I add into our NuGet package support for targeting both 4.5 and 4.6+ frameworks.

@OlegRa OlegRa changed the title dependencies Provide SDK version compatible with .NET Framework 4.5 Nov 14, 2019
@OlegRa
Copy link
Contributor

OlegRa commented Nov 14, 2019

@maztch I'll try to provide additional binaries compatible with .NET Framework 4.5 inside the existing NuGet package. The estimated time for the first alpha version availability is the end of this week.

OlegRa added a commit that referenced this issue Nov 14, 2019
OlegRa added a commit that referenced this issue Nov 14, 2019
OlegRa added a commit that referenced this issue Nov 14, 2019
* Issue #19 - convert all projects into new .csproj format for better multi-platform support.
* Issue #19 - add .NET Framework 4.5 as target and provide an old JWT package for it.
* Issue #19 - NuGet package `JWT` replaced with package `jose-jwt` (has better .NET 4.5 support).
@OlegRa
Copy link
Contributor

OlegRa commented Nov 14, 2019

@maztch Could you please try a new 1.3.0-alpha version of SDK and feel free to report any issues related to this release here.

@OlegRa
Copy link
Contributor

OlegRa commented Nov 19, 2019

@maztch Could you please confirm fact that the last 1.3.0-alpha version of the package solves your problem.

@maztch
Copy link
Author

maztch commented Nov 19, 2019

Working, txs

@OlegRa OlegRa closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants