Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from SetupCommon::initSetup() instead of later in SetupMenu::begin() - this moves, for example, init_routing() to SetupNG. And therefore also moved update_routing() from a menu action function to an NG set() action function. This change will allow being more selective in starting WiFi TCP server tasks, based on individual router settings rather than the bitfield variables as a whole. For example, rt_s1_s2 (which has nothing to do with WiFi) should not require starting up both 8881 and 8882 TCP servers. This cannot be done with init_routing() currently in SetupMenu::begin() since it is called after the WiFi TCP server tasks have been started. I also see other uses for this mechanism later, for example, unpacking additional settings bitfields, and handling an overall master_mode variable.