Clean up some codesmells #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imRohan
added
the
Work in Progress
imRohan
added
Ready for Review
With the recent addition of CodeClimate, a few code smells have been identified. Most can be cleaned up easily, and repeated logic abstracted into separate functions. * Cleaned up the BlocksController * Cleaned up routes file
imRohan
force-pushed
the
rl-fix-codesmells
branch
from
af7a3a4
to
fd09310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent addition of CodeClimate, a few code smells have been identified.
Most can be cleaned up easily, and repeated logic abstracted into separate functions.