Changed to double quotes in npm script #86
Conversation
|
I merged in the latest changes from master which lets the CI action run on pull requests. Could you please squash all of the commits into one please? Thanks! |
|
👍 Fixed it |
There was a problem hiding this comment.
The intended changes to package.json look good! 👍 I see there are other changes that you'll need to address, maybe rebase on master since these changes currently exist.
Also, could you please update your commit message to match the PR description? I've added a pull request template here
imRohan
added
Ready for Review
The single quotes in the package.json file did not work on windows. I changed to double quotes and escaped them with a backslash. (Tested on windows and linux). Resolves: #86
|
Sorry for the mess, I accidentaly updated the kaffarell/master branch with unrelated changes from the imRohan/master branch (Added the wrong remote url). Reverted these changes and made a new commit with only the intended changes (also following the guidelines). Hope this works! |
Single quotes don't work on windows, so I changed to double quotes and
escaped them with a backslash (should work on all platforms, tried on
windows and linux).