Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Round Bars Rendering Invalid (when differences are too high?) #43

Closed
sofakingforever opened this issue Jul 10, 2019 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@sofakingforever
Copy link

sofakingforever commented Jul 10, 2019

As seen in the screenshots below, when using rounded bars, and having the difference between the bars - we get this weird behavior.

When the Y values are something like 0,0,3,4 - everything is ok.
When the Y values are something like 0,0,30,1750 - the last bar is cut at the bottom.

(the longer one doesn't reach the real widget bottom or the shorter one overreaches. not sure.)

When turning off the rounded corners - the bars seem fine.

I tried debugging it for a bit but didn't really understand what's going on.
Let me know if there's anything else I can help you with.

Screenshot_20190711-003649
Screenshot_20190711-003700

@sofakingforever sofakingforever changed the title Round Bars Rendering Invalid (when differences are too high?) Bug: Round Bars Rendering Invalid (when differences are too high?) Jul 10, 2019
@sofakingforever
Copy link
Author

This one is from generating random numbers between 0-100 for all the bars

Screenshot_20190711-005241

@imaNNeo imaNNeo added the bug Something isn't working label Jul 11, 2019
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 11, 2019

Hi, this problem happens only when you set rounded corners ON, I supposed to reduce the width of the bars that their height is lower than their height (also it didn't works currently because codes were unused),
Bytheway, I decided to change the solution and now we show the bars that have low y (height) values with the height that is the same as with.
determine when you have a bar with 0.5 value and another one with 100,
we show the 0.5 bar with the minimum possible height, that is the width of them (because we show them as round lines, the minimum height is the with (such a circle) because we don't want to show ellipse).
Resolved in 0.1.4.
Thanks for contributing, Cheers!

@imaNNeo imaNNeo closed this as completed Jul 11, 2019
@sofakingforever
Copy link
Author

sofakingforever commented Jul 11, 2019

Amazing! Working perfectly now 😁

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 11, 2019

Thank you, your samples is amazing,
If it possible share it here with correct representatiom,
And maybe we have catalog in future, then I can add samples there.

@sofakingforever
Copy link
Author

Sure!

Screenshot_20190711-235813

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 12, 2019

your samples are beautiful,
If you can, make a PR and add one of them in the BarChart samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants