Feature to clip the data point along with radius. #897
Labels
Comments
prajwal27
pushed a commit
to prajwal27/fl_chart
that referenced
this issue
Feb 11, 2022
imaNNeo
pushed a commit
that referenced
this issue
Feb 11, 2022
* feat: Introduce 'clipBubble' attribute to scatter chart. * fix: remove `clipBubble` attribute and implement `clipData` function in scatter chart. * added issue fix #897 to changelog. * modify clip equation to resolve border issue. Co-authored-by: prajwal27wiijii <prajwal@wiijii.co>
|
It has been fixed in 0.45.0 with your help :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The Scatter chart in the image below does not clip the bubble.It considers only the data points. The
ScatterChartDatahas a attribute calledclipData, which checks if the data point is within the chart and then decides to clip it or not.However, it doesn't consider the radius of the bubble and hence, even if the data point is inside, the bubble might be so big that it causes it to go outside the axis, which is not a good UI/UX.
To Reproduce
It is fairly easy to reproduce. Take any example of scatter chart and increase the radius until you see it cross the axis.
Screenshots
Possible Solution
So, currently we have clipped the bubble (see the topmost bubble), and it doesn't cross the chart, but it does cross the axis. So, what I feel would be a better idea is to crop clip the bubble inside the chart. So, we get something like this
Here, the bubble doesn't cross the axis.
Versions
The text was updated successfully, but these errors were encountered: