fix: RadarChart crashes if all values in RadarDataSet are equal #1076
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the max and min values in a RadarDataSet are equal, the `drawTicks` method in `radar_chart_painter.dart` will enter an infinite loop. This is due to a for loop that fails to be incremented if the max and min values are equal, causing the loop to never meet its exit condition. I have replaced the for loop with one that will always exit. Resolves imaNNeo#882
Codecov Report
@@ Coverage Diff @@
## master #1076 +/- ##
=======================================
Coverage 86.32% 86.32%
=======================================
Files 45 45
Lines 2808 2808
=======================================
Hits 2424 2424
Misses 384 384
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Hi. Did you test it with your new logic? |
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the max and min values in a RadarDataSet are equal, the
drawTicksmethod inradar_chart_painter.dartwill enter an infinite loop.This is due to a for loop that fails to be incremented if the max and min values are equal, causing the loop to never meet its exit condition.
I have replaced the for loop with one that will always exit.
Resolves #882