Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient direction support on line chart #117

Merged

Conversation

kamilpowalowski
Copy link
Contributor

@kamilpowalowski kamilpowalowski commented Nov 23, 2019

I needed a way to show low and high values on the chart so I modified LineChartBarData implementation to support gradientFrom and gradientTo parameters based on similar logic from BarAreaData implementation.
With those changes making charts like the one in attachment is possible.

Screenshot_1574536012
Simulator Screen Shot - iPhone 11 - 2019-11-24 at 12 47 27

@kamilpowalowski kamilpowalowski force-pushed the feature/line-chart-line-gradient branch from dee68fb to 7d860cb Compare November 26, 2019 17:10
@imaNNeo
Copy link
Owner

imaNNeo commented Nov 27, 2019

Hi @kamilpowalowski.
Good implementation, I've enjoyed it.
Thanks!

@imaNNeo imaNNeo merged commit a9ebb76 into imaNNeo:master Nov 27, 2019
@kamilpowalowski kamilpowalowski deleted the feature/line-chart-line-gradient branch November 27, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants