Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getBestInitialIntervalValue() problem with values above or below zero #894

Merged
merged 6 commits into from
Feb 11, 2022

Conversation

imaNNeo
Copy link
Owner

@imaNNeo imaNNeo commented Feb 4, 2022

Now we can change baselineX and baselineY property of our axis-based charts (default is 0).
It solves a problem mentioned here: #893

Check sample below (source code):

simplescreenrecorder-2022-02-04_18.53.47.mp4

@imaNNeo imaNNeo changed the title Fix getBestInitialIntervalValue() problem with values above or below … Fix getBestInitialIntervalValue() problem with values above or below zero Feb 4, 2022
@imaNNeo imaNNeo force-pushed the hotfix/initial-interval-baseline branch from 07a5ced to 45ca851 Compare February 11, 2022 20:31
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #894 (55ca1cd) into dev (445c032) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #894      +/-   ##
==========================================
+ Coverage   80.87%   80.98%   +0.10%     
==========================================
  Files          32       32              
  Lines        3007     3024      +17     
==========================================
+ Hits         2432     2449      +17     
  Misses        575      575              
Impacted Files Coverage Δ
lib/src/chart/bar_chart/bar_chart_painter.dart 86.55% <100.00%> (+0.05%) ⬆️
...b/src/chart/base/axis_chart/axis_chart_helper.dart 100.00% <100.00%> (ø)
.../src/chart/base/axis_chart/axis_chart_painter.dart 97.63% <100.00%> (+0.02%) ⬆️
lib/src/chart/line_chart/line_chart_painter.dart 80.33% <100.00%> (+0.10%) ⬆️
...src/chart/scatter_chart/scatter_chart_painter.dart 95.95% <100.00%> (+0.05%) ⬆️
lib/src/utils/utils.dart 89.38% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445c032...55ca1cd. Read the comment docs.

@imaNNeo imaNNeo force-pushed the hotfix/initial-interval-baseline branch 4 times, most recently from 872f5ef to cce76c1 Compare February 11, 2022 20:43
@imaNNeo imaNNeo force-pushed the hotfix/initial-interval-baseline branch from cce76c1 to e8953f2 Compare February 11, 2022 20:43
@imaNNeo imaNNeo merged commit 19091b9 into dev Feb 11, 2022
imaNNeo added a commit that referenced this pull request Feb 12, 2022
…zero (#894)

* Fix getBestInitialIntervalValue() problem with values above or below zero, #893.

* Add `baselineX` and `baselineY` property to all of our axis-based charts (Line, Bar, Scatter). default is zero, #893.

* Remove all linux/flutter/ephemeral files from example directory

* Update CHANGELOG.md, bar_chart.md, and line_chart.md

* Update line_chart.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant