Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this crate ships with both
fdeflate
andflate2
as dependencies. There's a lot of duplicated code between them including two full decompressors and a chunk of duplicated logic on the encode path. Iffdeflate
gains a general purpose compressor, it would be nice for us to remove the duplication by default.This PR moves the user-facing guarantee that
flate2
is used as the compression backend behind a non-default feature flag. Internally,flate2
is still used for all compression levels other thanNoCompression
andFdeflateUltraFast
.