Berid of most (all?) warnings #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
force-pushed
the
be_not_aware
branch
from
09fa828
to
cedfa1c
Compare
JohnTitor
reviewed
May 22, 2020
nabijaczleweli
force-pushed
the
be_not_aware
branch
from
cedfa1c
to
917238c
Compare
HeroicKatora
approved these changes
May 22, 2020
|
Looks like the crate itself is free of warnings. Very nice 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly the vomit from
ExtendedColorTypein each and every build, but tested with no features, one feature at a time, and all features, all of which have just the two warnings fixed by #1205.