Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document WebP encoder limitations #2314

Merged

Conversation

Shnatsel
Copy link
Contributor

Explain the trade-offs involved and link to example code for encoding with libwebp.

@Shnatsel
Copy link
Contributor Author

I see a lot of my PRs are approved but not merged. Does the project have a policy to require approval from several maintainers before merging a PR?

@HeroicKatora HeroicKatora merged commit c8d67ec into image-rs:main Aug 26, 2024
30 of 32 checks passed
@HeroicKatora
Copy link
Member

@Shnatsel CI hadn't finished when I pressed it (or Github didn't load). If you can, feel free to press the merge button on good judgment especially with approval there. Also

  • clippy is broken again based on a long doc paragraph
  • exr needs the latest version of miniz_oxide

Putting up this checklist just so I can communicate (including to myself) when I get around to fixing them.

@Shnatsel
Copy link
Contributor Author

I do not have PR merge permissions on this repo.

@HeroicKatora
Copy link
Member

Let's fix that as well, you'll want them in the coming months in any case I suppose.

@fintelia
Copy link
Contributor

@Shnatsel I just added you to the 'Reviewers' team. That should give you write permissions to all the repositories under the image-rs org

@Shnatsel
Copy link
Contributor Author

Thanks! I'll try not to make too much of a mess 😅

@fintelia
Copy link
Contributor

Parts of this crate predate not just Rust 1.0, but crates.io itself. It'll always be at least somewhat messy 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants