-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: ship with built-in FreeImage #3
base: master
Are you sure you want to change the base?
Conversation
I'm trying to run this on my Mac. Using edit: ah, can also do Not there yet, but I'm making progress. This seems like a good resource: https://www.ultraengine.com/community/topic/59665-freeimage-build-errors/ When I know what to change, can I just change the FreeImage source or do you want it to be patched at runtime somehow? |
Now stuck at
|
Thanks @almarklein 🎉
Yes and no. Under the hood That said, it's perfectly fine to use it and, once things work, I can "port" it to An alternative could be to use the build system that ships with FreeImage (makefiles) and then just copy the binary into the target location. If that works directly without making modifications then I'd prefer that solution.
So far, I've downloaded the FreeImage source directly from Sourceforge, because I thought this is the easiest way to say "look, this is just vanilla FreeImage". However, if we do need to modify the source then I think it will be much easier for us to vendor the code. Which option do you think is less work for us? |
The issue was that secrets are unavailable on PRs...
Right, I found out after I posted :)
I suppose it'd be easier if it stays visible what diffs we're applying, so that in case of an update they still work and/or can be updated ... |
This PR adds plumbing to download, compile, and package the freeimage binary and make it part of the distributed wheel.