Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imagemin API change breaks example in README #26

Closed
simonxabris opened this issue Nov 6, 2019 · 1 comment
Closed

Imagemin API change breaks example in README #26

simonxabris opened this issue Nov 6, 2019 · 1 comment

Comments

@simonxabris
Copy link

Hi

With the v7 release Imagemin introduced some breaking changes to the public API which means the example code in the readme no longer works.

I think the example in the readme should be updated so that it works with the latest major imagemin version or provide two examples, one for v7 and one for v6. If you think this is a good idea I'd be happy to submit a PR!
@1000ch
Copy link
Contributor

1000ch commented Jun 1, 2020

Solved by #28, very sorry for delay 🙏

@1000ch 1000ch closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1000ch @simonxabris