Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed qrOutput reference so cleanup works now #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed qrOutput reference so cleanup works now #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Sources/CameraManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,10 +799,15 @@ open class CameraManager: NSObject, AVCaptureFileOutputRecordingDelegate, UIGest
guard let captureSession = self.captureSession
else { return }

let output = AVCaptureMetadataOutput()
qrOutput = AVCaptureMetadataOutput()

guard captureSession.canAddOutput(output)
else { return }
guard let output = qrOutput else {
return
}

guard captureSession.canAddOutput(output) else {
return
}

qrCodeDetectionHandler = handler
captureSession.addOutput(output)
Expand Down Expand Up @@ -832,7 +837,7 @@ open class CameraManager: NSObject, AVCaptureFileOutputRecordingDelegate, UIGest
/**
The stored meta data output; used to detect QR codes.
*/
private var qrOutput: AVCaptureOutput?
private var qrOutput: AVCaptureMetadataOutput?

/**
Check if the device rotation is locked
Expand Down