feat: modify tsconfig noImplicitAny: false => true

imagine10255 · Sep 21, 2023 · 0ff8855 · 0ff8855
1 parent 2c840fc
commit 0ff8855
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 11 deletions.
diff --git a/src/BearCarousel.tsx b/src/BearCarousel.tsx
@@ -33,7 +33,7 @@ interface IState {
 
 
 class BearCarousel extends React.Component<IBearCarouselProps, IState> {
-    static defaultProps = {
+    static defaultProps: IBearCarouselProps = {
         data: undefined,
         slidesPerView: 1,
         slidesPerGroup: 1, // 不可為小數
@@ -50,7 +50,6 @@ class BearCarousel extends React.Component<IBearCarouselProps, IState> {
         moveTime: 500,
         autoPlayTime: 5000,
         initStartPlayTime: 1500,
-        defaultActivePage: 1,
         isSlideItemMemo: false,
     };
     _isEnableGpuRender = checkIsDesktop();

diff --git a/src/manager/Configurator/types.ts b/src/manager/Configurator/types.ts
@@ -3,7 +3,6 @@ import {IBreakpointSetting, TSlidesPerViewActual} from '../../types';
 export interface ISetting extends IBreakpointSetting {
     slidesPerViewActual?: TSlidesPerViewActual
     moveTime?: number,
-    defaultActivePage?: number,
     autoPlayTime?: number,
     initStartPlayTime?: number,
     isDebug?: boolean,

diff --git a/src/manager/Elementor/Elementor.ts b/src/manager/Elementor/Elementor.ts
@@ -5,6 +5,7 @@ import {getMoveDistance, getMovePercentage, getStartPosition} from './utils';
 import Configurator from '../Configurator';
 import Stater from '../Stater';
 import {IPercentageInfo} from '../../types';
+import {getObjectKeys} from '../../utils';
 
 class Elementor {
     _rootRef: RefObject<HTMLDivElement> = createRef();
@@ -206,7 +207,8 @@ class Elementor {
         if(this._configurator.setting.moveEffect?.moveFn){
             const moveStyles = this._configurator.setting.moveEffect.moveFn(percentageInfo);
             if(moveStyles){
-                Object.keys(moveStyles).forEach(rowStyleKey => {
+                getObjectKeys(moveStyles).forEach(rowStyleKey => {
+                    // @ts-ignore
                     el.style[rowStyleKey] = moveStyles[rowStyleKey];
                 });
                 if(isUseAnimation){

diff --git a/src/types.ts b/src/types.ts
@@ -128,4 +128,3 @@ export type TToNext = () => void
 
 
 
-
diff --git a/src/utils.ts b/src/utils.ts
@@ -103,15 +103,17 @@ export function getLoopResetIndex(activeActualIndex: number, residue: number): n
 
 
 
+type ObjectKeys<T> = Array<keyof T>;
 
-
-
+export function getObjectKeys<T>(props: T): ObjectKeys<T> {
+    return Object.keys(props) as ObjectKeys<T>;
+}
 
 export function isPropsDiff(props: IBearCarouselProps, nextProps: IBearCarouselProps, exclude: string[]) {
-    const filterProps = Object.keys(props)
-        .filter(key => typeof props[key] !== 'function' && !exclude.includes(key))
+    const filterProps = getObjectKeys(props)
+        .filter((key) => typeof props[key] !== 'function' && !exclude.includes(key))
         .map(key => props[key]);
-    const nextFilterProps = Object.keys(nextProps)
+    const nextFilterProps = getObjectKeys(nextProps)
         .filter(key => typeof nextProps[key] !== 'function' && !exclude.includes(key))
         .map(key => nextProps[key]);
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -6,7 +6,7 @@
       "dom.iterable",
       "esnext"
     ],
-    "noImplicitAny": false,
+    "noImplicitAny": true,
     "allowJs": true,
     "skipLibCheck": true,
     "esModuleInterop": true,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -128,4 +128,3 @@ export type TToNext = () => void