Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlantUML style #4

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

idonuntius
Copy link
Contributor

@idonuntius idonuntius commented Oct 10, 2023

Description

The current PlantUML style applies the .noView style to Nodes under .noView. Therefore, fix it.

  • Fix PlantUML style
    • Color codes were corrected to lowercase
  • Nodes with no corresponding view had <noview> displayed. With this fix, nodes with a corresponding view display <hasView>.

Output

Before

@startmindmap
<style>
mindmapDiagram {
  . * {
    BackGroundColor #FFF
    LineColor #192f60
    Shadowing 0.0
    RoundCorner 20
    LineThickness 2.0
  }
  .noView * {
    BackGroundColor #FFF
    LineColor #d20b52
  }
}
</style>
* Root
** LoggedOut<<noView>>
*** TermsOfUse
**** FailedLoading
*** Welcome
**** SignInFailedDialog
**** ForgotPassword
***** SMSAuthentication
****** ResetPassword
** LoggedIn<<noView>>
@endmindmap

bP51IyGm48Nl-HK3tdfOQq51A6NLfR9GMR6hdcCpcuPjPoH9AIBxturfaBrwAlFDU_DUoTfvQVreI8toKvJEVmrOYJHlZDHMZl0j05QGnI_0lUoEZvOdKWyyi8MBkgxZeZ642LtT5eURFDAsbufdGnhorK9U5gybj53aVzPzRxeZeNDGHE7fDvNupU3yhsnLv1_NHJnm4kLb-YMHXLps8ikWOQrHxIPVbilvgWeuWptQqUqE

After

@startmindmap
<style>
mindmapDiagram {
  BackgroundColor translate
  LineColor #d20b52
  FontColor #d20b52
  LineThickness 2.0

  node {
    BackgroundColor #fff
    RoundCorner 30
  }

  arrow {
    LineColor #192f60
  }

  .hasView {
    LineColor #192f60
    FontColor #192f60
  }
}
</style>
* Root<<hasView>>
** LoggedOut
*** TermsOfUse<<hasView>>
**** FailedLoading<<hasView>>
*** Welcome<<hasView>>
**** SignInFailedDialog<<hasView>>
**** ForgotPassword<<hasView>>
***** SMSAuthentication<<hasView>>
****** ResetPassword<<hasView>>
** LoggedIn
@endmindmap

PP91IyD048Nl-oiMUikXneY244hLKYXKAhRgUSnEjakJ6TcTKaJwtrtDIcrotFU-zsOcP1e4lBIEJ0iVgWposU14fVVCWVNGwY-bzJrKE-jvJ-Q16_PQF51eG31wIqVOgIDJvE_NHTJcJDBNdhku9_JwAa_1pTPLEy8GT37ELHI93VwE70uTrNKTZUCF1jxp8N6d1VJeyhQeR_8_Qho5yEfm29wuVxkUfO-gl4ZVGsLnTvQo

@idonuntius idonuntius force-pushed the fix/plant-uml-style branch 2 times, most recently from 82edb11 to 9d70fb8 Compare October 10, 2023 13:18
@idonuntius
Copy link
Contributor Author

idonuntius commented Oct 10, 2023

下記のようにデフォの色が #192f60.noView#d20b52 にする方向も考えたが、画像のように LoggedOutTermsOfUse , Welcome を結ぶボーダーの色が #d20b52 になってしまうため諦めました。

原因としては arrow のようなタグ?より、 .noView のようなクラス?の方が優先順位が高いようで厳しそうでした。(記入する順番を変えても優先順位は変わりませんでした。)

@startmindmap
<style>
mindmapDiagram {
  BackgroundColor translate
  LineColor #192f60
  FontColor #192f60
  LineThickness 2.0

  node {
    BackgroundColor #fff
    RoundCorner 30
  }

  arrow {
    LineColor  #192f60
  }

  .noView {
    LineColor #d20b52
    FontColor #d20b52
  }
}
</style>
* Root
** LoggedOut<<noView>>
*** TermsOfUse
**** FailedLoading
*** Welcome
**** SignInFailedDialog
**** ForgotPassword
***** SMSAuthentication
****** ResetPassword
** LoggedIn<<noView>>
@endmindmap

PP5DQm8n48Rl-HK1RnwitT92OH7xWI1OBDMsvtGp6uFPcJ8PaIB-zyRT8B8UvtcVILwIQHJ3qdYqZVbLPPI_01ELvrTl79j67vJMpwRQEgOTsXSAn5hOO0n6GAKGoK9hNNk3kgxROE4HChfzBEg7SKjdX79DFxfzHc1zDpwlhpU-sYB4g8lHYHvFTnjcskj3xuxpSTaQ8NrvsFUrWIt6F_V5kKgV7jLHbJVvLOQf5uaQ3lM2

Copy link
Owner

@imairi imairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈 LGTM 🌈

ありがとうございます!

@imairi imairi merged commit 703e91c into imairi:master Oct 16, 2023
@idonuntius idonuntius deleted the fix/plant-uml-style branch November 11, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants