Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauled the settings tab #1423

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

ergoxiv
Copy link
Contributor

@ergoxiv ergoxiv commented Dec 29, 2024

Note: Aether-Tools/AetherToolsWpf#6 should be merged before this can be rebased and merged.

Moves Anamnesis' settings into a page-style layout with four categories:

  • General: Contains all interface and file/directory settings.
  • Input & Hotkeys: Contains the rotation-slider wrap setting & all hotkey settings.
  • Personalization: Contains the application theme and gallery settings.
  • Connections: Contains all external service settings.

If you have any feedback on the design, let me know and we can think of better solutions.

@ergoxiv
Copy link
Contributor Author

ergoxiv commented Dec 29, 2024

If you think the settings tab needs a search bar, now would be the time to implement it as searching through pages would require a somewhat different approach: Instead of having a different XAML file for each page, everything would be in a single file with visibility toggles determining what's shown on the screen.

Implemented.

@ergoxiv ergoxiv force-pushed the feature/settings-rework branch from 2d3b2e1 to d6f7b24 Compare December 30, 2024 20:16
@StoiaCode
Copy link
Contributor

LGTM?

@ergoxiv
Copy link
Contributor Author

ergoxiv commented Dec 31, 2024

Should be ready to merge then. I moved the lib commit checkout from my fork to the main repo.

@StoiaCode StoiaCode merged commit 2b54431 into imchillin:testing Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants