Render a proper connection string without username or password #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows Adapter::Base#connection_string to render a connection string such as postgres://localhost/db_name previously, when given no username or password, it would render postgres://@localhost/db_name, which is invalid.
imdrasil
approved these changes
Feb 20, 2024
|
@robacarp please address mysql related issue and we will be able to merge this PR |
|
@robacarp it looks like failed tests aren't connected with your changes. I'll take a look on this weekend |
|
@imdrasil Have you had time to look into what is blocking the CI ? 🤔 |
|
I was just an issue with the latest mysql version - my JSON patch to mysql driver causes very strange bug with |
|
all set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Adapter::Base#connection_string to render a connection string such as postgres://localhost/db_name
previously, when given no username or password, it would render postgres://@localhost/db_name, which is an invalid connection string.
Any background context you want to provide?
Re my issues getting started at #444 -- the first thing I tried to do was to connect to my local database without a username or password.
I ran into this with posgresql, but I did not have a local mysql installation available for testing.
Release notes
Config
[BUGFIX] Now connection strings can be rendered without username or password.