chore: change refs of master to main #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickfogerty
changed the title
sherwinski
approved these changes
Jun 26, 2020
| @@ -40,7 +40,7 @@ Define the following requirement in your `composer.json` file: | |||
| ```json | |||
| { | |||
| "require": { | |||
| "imgix/imgix-php": "dev-master" | |||
| "imgix/imgix-php": "dev-main" | |||
There was a problem hiding this comment.
Just thinking out loud, this worries me that changing the base branch name could have negative effects for users. However, it looks like both tags are available online -- thanks to our auto-updating hooks.
Because of that, I think it's ok to move forward with this now, but it would be worth modifying this install step with something like what is described in #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes any references from the master branch to the main branch, now that it is the default.