refactor: relax validation for min/max width values #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR relaxes the constraints on max width values. Prior to this PR max width values were bounded, now they are not. The only restriction is that image width values (both max and min) be greater than or equal to zero (and that the max value is not less than the min value).
sherwinski
approved these changes
Jun 9, 2020
ericdeansanchez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the constraints on max width values. Prior to this PR
max width values were bounded, now they are not. The only restriction
is that image width values (both max and min) be greater than or equal
to zero (and that the max value is not less than the min value).