Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support Vue 3 #441

Closed
wants to merge 3 commits into from
Closed

chore: support Vue 3 #441

wants to merge 3 commits into from

Conversation

frederickfogerty
Copy link
Contributor

@frederickfogerty frederickfogerty commented Apr 22, 2022

Fixes #410

TODO

  • rename project to @imgix/vue
  • move Vue v2 support to a specific branch
  • update Vue v2 readme to reflect this change

@frederickfogerty frederickfogerty requested a review from a team as a code owner April 22, 2022 10:40
@commit-lint
Copy link

commit-lint bot commented Apr 22, 2022

Chore

  • deps: update deps for vue 3 compatibility (109c9a6)
  • use dataTestId prop (c5ce9d3)
  • stop cypress from recording videos (998c781)
  • release: 2.9.0-rc.1 (0825cca)
  • picture: update slot syntax to vue 3 (1cd219c)

Build System

Features

  • use createApp api (7b4dd29)
  • use global api to register components (eb7e1ad)
  • use vue 3 global and composition api in ix-img (0e05aa9)
  • use vue 3 global and composition api in ix-picture (3c3d626)
  • use vue 3 global and composition api in ix-source (619ed84)

Tests

  • use vue 3 global api & new testing-library screen api (2e4ea60)
  • use vue 3 global createApp api (de07453)
  • skip picture mode spec (23fa1a6)
  • temporarily disable breaking e2e test (3f48852)
  • picture: remove testing library dep (bd646b3)

Bug Fixes

  • change method name to the correct name (801b53b)
  • use attrs destrucuring to access context (83536d6)

Code Refactoring

Styles

Documentation

  • README: update README with vue 3 syntax (b419dbd)

Lint

  • disable eslint for shims and spec (fe07777)

Continuous Integration

  • use openssl-legacy-provider (1dc311f)
  • use chrome to run headless tests (fe9a14e)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link
Contributor

@luqven luqven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a handful of nitpicks 👍🏼

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/simple/static-api.vue Outdated Show resolved Hide resolved
frederickfogerty and others added 3 commits April 26, 2022 09:22
Co-authored-by: Luis H. Ball Jr. <lball@imgix.com>
Co-authored-by: Luis H. Ball Jr. <lball@imgix.com>
@frederickfogerty
Copy link
Contributor Author

This was merged locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3 Support
2 participants