Remove ImStr and ImString #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm liking the big, breaking changes overall! Can't appliciate enough your effort :) For now, Is it like WIP or changed to not make it an iterator? Thank you. |
|
@toyboot4e good catch! I changed it to use an iterator and then decided that shouldn't be in this PR (I was on an airplane and was truly going wild on the code base). I'll remove that comment, though I DID add the rest of the combo box functions |
|
Okay! Please all, take a look and if you have opinions on these changes, let me know! |
|
yes, looks excellent, you have my blessing to merge this mr sanbox |
and i'll need to check the imgui docs example with std::string to get a reference to how to do it properly.
fixed some instability and added a hacky shim to input_text functions. We're looking okay so far, but more testing will be needed
also removed the previous notion that some things required &str -- we figured out how to not need that
|
me accepting my own pr: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still in progress but is quite close. Please let me know your thought. I am not done with the trait, but I do like the simplicity of this setup