fix TCP Timestamps

imguoliwei · Apr 26, 2022 · d90ebf8 · d90ebf8
1 parent 4f7728c
commit d90ebf8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/ua2f-mix.cpp b/src/ua2f-mix.cpp
@@ -79,7 +79,9 @@ class TcpOptionsScanner {
     [[nodiscard]] bool hasNext() const { return curr < bound; }
 
     void next(){
-        if(!hasNext()) throw std::out_of_range("TcpOptionsScanner out of bound");
+        using std::out_of_range;
+        if(!hasNext()) throw out_of_range("TcpOptionsScanner out of bound");
+        if(*curr == TCPOPT_EOL) throw out_of_range("TcpOptionsScanner's pointer reach end of option list");
         if(*curr == TCPOPT_NOP){
             ++curr;
         } else {
@@ -217,6 +219,7 @@ static bool clearTcpTimestamps(pkt_buff *const pktb, const variant<iphdr*, ip6_h
     if(tcpPkHdl->doff * 4 == sizeof(tcphdr)) return false;
     for(TcpOptionsScanner optScanner(tcpPkHdl); optScanner.hasNext(); optScanner.next()){
         auto const curr = optScanner.getCurrOption();
+        if(*curr == TCPOPT_EOL) return false;
         if(*curr != TCPOPT_TIMESTAMP) continue;
         const unsigned int dataOffset = reinterpret_cast<const char*>(tcpPkHdl) - (
                 isIPv4 ?