Added Credential Provider for the access.logs.add event #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jblattel this LGTM but I would like to test it before merging. I will see if I can do that in the next few days. Were you able to verify all the different authentication methods? |
@imhotep - well to the extent that I know of (NFC card, pin code, through the phone app, and Mobile phone NFC tap, from the UA viewer) - I did not test any 3rd party NFC devices - but presume they will come through as "NFC" #"REMOTE_THROUGH_UAH" , "NFC" , "MOBILE_TAP" , "PIN_CODE" |
imhotep
requested changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ability to determine how the actor has initiated the access event - remotely (through access app or viewer) or at the reader itself with a phone or nfc card.