Facilitate Jupyter testing with nbmake #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @bnmajor |
oeway
reviewed
Sep 21, 2022
| else: | ||
| # nbmake | ||
| self.kernel_id = Path(connection_file).stem | ||
| print('kernel_id', self.kernel_id) |
There was a problem hiding this comment.
Do we want to keep the print statement here?
|
Could you please run |
With nbmake, the connection file is a temp file such as '/tmp/tmpabc123.json'. Use the name of this file for the kernel id in this case.
Yes, done 👍 Could we please get a release with this? It will help us get started on testing 💚 |
|
Great!
Yes, the CI will make the release if we change the version number in 3 places (VERSION file, pakcage.json and pakcage-lock.json). |
|
@oeway awesome, thanks! |
| connection_file = ipykernel.connect.get_connection_file() | ||
| if "kernel-" in connection_file: | ||
| self.kernel_id = re.search( | ||
| "kernel-(.*).json", ipykernel.connect.get_connection_file() |
There was a problem hiding this comment.
Can we not use connection_file here in the re.search call?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With nbmake, the connection file is a temp file such as '/tmp/tmpabc123.json'. Use the name of this file for the kernel id in this case.