Return sequences instead of FrozenArrays #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bialpio
approved these changes
Jun 11, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 11, 2024
SHA: 6b5297b Reason: push, by toji Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
As agreed on in today's call, having
getHitTestResultsandgetHitTestResultsForTransientInputreturnFrozenArrays isn't being used for optimization purposes, and is unusual relative to other Web APIs. This PR changes them both to sequences, which shouldn't result in any user-facing breaking behavior.Preview | Diff