Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eye viewport widths larger than screen on iphone 5 and ipod 6 #147

Closed
tommytee opened this issue Sep 6, 2016 · 6 comments
Closed

eye viewport widths larger than screen on iphone 5 and ipod 6 #147

tommytee opened this issue Sep 6, 2016 · 6 comments

Comments

@tommytee
Copy link

tommytee commented Sep 6, 2016

Each eye viewport seems clipped. ( or zoomed in? )
( screenshots from iphone 5 )

img_0003
img_0008
img_0010
img_0007

For comparison here are similar android screenshots

screenshot_20160905-200543
screenshot_20160905-200822
screenshot_20160905-200704

I'm having the same problem on an ipod 6. (both report a screen resolution of 640 x 1136) I have not tested other ios devices.

I can quick-fix issue by changing the dpi in the dpdb.
"dpi": [ 317.1, 320.2 ] changed to [ 225, 227.2 ]

but this seems wrong.

@borismus
Copy link
Contributor

Yes definitely an issue... Unfortunately don't have an iPhone 5 to test on.

@cvan
Copy link
Contributor

cvan commented Sep 18, 2016

Could be different, but perhaps this issue is related to #140?

@brianchirls
Copy link
Contributor

I can confirm that I'm seeing the same viewports in iPhone 5 simulator. But are we sure this is wrong? Is there a reference somewhere of what it's supposed to look like on an iPhone 5?

@borismus I recall there was some talk last year about setting up some documentation and/or a repo for dpdb. Do you know if that's gonna happen? It might make it easier to debug issues like this.

@borismus
Copy link
Contributor

Good point, might actually not be wrong. Does it look wrong on device?

@brian, unfortunately given my team's focus on Daydream, just haven't had
time to split things up or add to dpdb.

On Mon, Sep 19, 2016 at 9:09 AM Brian Chirls notifications@github.com
wrote:

I can confirm that I'm seeing the same viewports in iPhone 5 simulator.
But are we sure this is wrong? Is there a reference somewhere of what it's
supposed to look like on an iPhone 5?

@borismus https://github.com/borismus I recall there was some talk last
year about setting up some documentation and/or a repo for dpdb. Do you
know if that's gonna happen? It might make it easier to debug issues like
this.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#147 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQ8gOkzPs4asLUtY7DmVShk9imHGOksks5qrrOwgaJpZM4J1eTg
.

@tommytee
Copy link
Author

tommytee commented Sep 19, 2016

It is definitely wrong. (just look at it) I have an iphone 5 and am willing to spend some time on this if someone could point me in the right direction.

@tommytee
Copy link
Author

tommytee commented Jan 5, 2017

I have a new ipod touch and cardboard viewer. its the same, seems less than ideal, but may be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants