Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Host Check #268

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Disable Host Check #268

merged 1 commit into from
Jun 23, 2017

Conversation

dmarcos
Copy link
Contributor

@dmarcos dmarcos commented Jun 22, 2017

It seems that WebPack tightened the security and the dev workflow I'm used to does not work anymore.
npm start and visiting localhost:8080 locally or the ip.of.my.server:8080 from a machine in my network returns an Invalid Host header error message. This PR disables the security host check on the package.json and everything works as it used to on my Windows boxes. The implications go a bit over my head so feel free to suggest an alternative. I found some literature here:

webpack/webpack-dev-server#887
webpack/webpack-dev-server#147 (comment)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@dmarcos
Copy link
Contributor Author

dmarcos commented Jun 22, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jsantell
Copy link
Contributor

I ran into this as well -- thanks!

@jsantell jsantell merged commit 942a945 into immersive-web:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants