pr feedback

cli/src/api/open-api/api.ts

@@ -1818,7 +1818,7 @@ export interface PersonResponseDto {
      * @type {boolean}
      * @memberof PersonResponseDto
      */
-    'hidden': boolean;
+    'isHidden': boolean;
 }
 /**
  * 
@@ -1843,7 +1843,7 @@ export interface PersonUpdateDto {
      * @type {boolean}
      * @memberof PersonUpdateDto
      */
-    'hidden'?: boolean;
+    'isHidden'?: boolean;
 }
 /**
  * 

server/immich-openapi-specs.json

@@ -5896,15 +5896,15 @@
           "thumbnailPath": {
             "type": "string"
           },
-          "hidden": {
+          "isHidden": {
             "type": "boolean"
           }
         },
         "required": [
           "id",
           "name",
           "thumbnailPath",
-          "hidden"
+          "isHidden"
         ]
       },
       "PersonUpdateDto": {
@@ -5918,7 +5918,7 @@
             "type": "string",
             "description": "Asset is used to get the feature face thumbnail."
           },
-          "hidden": {
+          "isHidden": {
             "type": "boolean",
             "description": "Person visibility"
           }

server/src/domain/person/person.dto.ts

@@ -24,7 +24,7 @@ export class PersonUpdateDto {
   @IsOptional()
   @IsBoolean()
   @Transform(toBoolean)
-  hidden?: boolean;
+  isHidden?: boolean;
 }
 
 export class MergePersonDto {
@@ -36,15 +36,15 @@ export class PersonResponseDto {
   id!: string;
   name!: string;
   thumbnailPath!: string;
-  hidden!: boolean;
+  isHidden!: boolean;
 }
 
 export function mapPerson(person: PersonEntity): PersonResponseDto {
   return {
     id: person.id,
     name: person.name,
     thumbnailPath: person.thumbnailPath,
-    hidden: person.hidden,
+    isHidden: person.isHidden,
   };
 }
 

server/src/domain/person/person.service.ts

@@ -58,8 +58,8 @@ export class PersonService {
       await this.jobRepository.queue({ name: JobName.SEARCH_INDEX_ASSET, data: { ids } });
     }
 
-    if (dto.hidden !== undefined) {
-      person = await this.repository.update({ id, hidden: dto.hidden });
+    if (dto.isHidden !== undefined) {
+      person = await this.repository.update({ id, isHidden: dto.isHidden });
       const assets = await this.repository.getAssets(authUser.id, id);
       const ids = assets.map((asset) => asset.id);
       await this.jobRepository.queue({ name: JobName.SEARCH_INDEX_ASSET, data: { ids } });

server/src/immich/api-v1/asset/asset.service.ts

@@ -280,7 +280,13 @@ export class AssetService {
     const asset = await this._assetRepository.getById(assetId);
 
     if (allowExif) {
-      return mapAsset(asset);
+      const data = mapAsset(asset);
+
+      if (data.people) {
+        data.people = data.people.filter((person) => !person.isHidden);
+      }
+
+      return data;
     } else {
       return mapAssetWithoutExif(asset);
     }

server/src/infra/entities/person.entity.ts

@@ -37,5 +37,5 @@ export class PersonEntity {
   faces!: AssetFaceEntity[];
 
   @Column({ default: false })
-  hidden!: boolean;
+  isHidden!: boolean;
 }

server/src/infra/migrations/1689281196844-AddHiddenFaces.ts

@@ -4,11 +4,11 @@ export class Infra1689281196844 implements MigrationInterface {
     name = 'Infra1689281196844'
 
     public async up(queryRunner: QueryRunner): Promise<void> {
-        await queryRunner.query(`ALTER TABLE "person" ADD "hidden" boolean NOT NULL DEFAULT false`);
+        await queryRunner.query(`ALTER TABLE "person" ADD "isHidden" boolean NOT NULL DEFAULT false`);
     }
 
     public async down(queryRunner: QueryRunner): Promise<void> {
-        await queryRunner.query(`ALTER TABLE "person" DROP COLUMN "hidden"`);
+        await queryRunner.query(`ALTER TABLE "person" DROP COLUMN "isHidden"`);
     }
 
 }

server/test/fixtures.ts

@@ -1160,7 +1160,7 @@ export const personStub = {
     name: '',
     thumbnailPath: '/path/to/thumbnail.jpg',
     faces: [],
-    hidden: false,
+    isHidden: false,
   }),
   withName: Object.freeze<PersonEntity>({
     id: 'person-1',
@@ -1171,29 +1171,7 @@ export const personStub = {
     name: 'Person 1',
     thumbnailPath: '/path/to/thumbnail.jpg',
     faces: [],
-    hidden: false,
-  }),
-  isHidden: Object.freeze<PersonEntity>({
-    id: 'person-1',
-    createdAt: new Date('2021-01-01'),
-    updatedAt: new Date('2021-01-01'),
-    ownerId: userEntityStub.admin.id,
-    owner: userEntityStub.admin,
-    name: 'Person 1',
-    thumbnailPath: '/path/to/thumbnail.jpg',
-    faces: [],
-    hidden: false,
-  }),
-  isnotHidden: Object.freeze<PersonEntity>({
-    id: 'person-1',
-    createdAt: new Date('2021-01-01'),
-    updatedAt: new Date('2021-01-01'),
-    ownerId: userEntityStub.admin.id,
-    owner: userEntityStub.admin,
-    name: 'Person 1',
-    thumbnailPath: '/path/to/thumbnail.jpg',
-    faces: [],
-    hidden: true,
+    isHidden: false,
   }),
   noThumbnail: Object.freeze<PersonEntity>({
     id: 'person-1',
@@ -1204,7 +1182,7 @@ export const personStub = {
     name: '',
     thumbnailPath: '',
     faces: [],
-    hidden: false,
+    isHidden: false,
   }),
   newThumbnail: Object.freeze<PersonEntity>({
     id: 'person-1',
@@ -1215,7 +1193,7 @@ export const personStub = {
     name: '',
     thumbnailPath: '/new/path/to/thumbnail.jpg',
     faces: [],
-    hidden: false,
+    isHidden: false,
   }),
   primaryPerson: Object.freeze<PersonEntity>({
     id: 'person-1',
@@ -1226,7 +1204,7 @@ export const personStub = {
     name: 'Person 1',
     thumbnailPath: '/path/to/thumbnail',
     faces: [],
-    hidden: false,
+    isHidden: false,
   }),
   mergePerson: Object.freeze<PersonEntity>({
     id: 'person-2',
@@ -1237,7 +1215,7 @@ export const personStub = {
     name: 'Person 2',
     thumbnailPath: '/path/to/thumbnail',
     faces: [],
-    hidden: false,
+    isHidden: false,
   }),
 };