-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer the same album sorting options on mobile as on web #3804
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello, you only need to add translation key to the EN_US json file, the other files will eventually be autogenerated |
@alextran1502 I wasn’t aware of that. Should I change something? |
You can revert the changes of all the other languages beside the english file |
What about this spelling correction (I'm a native German speaker)? |
The changes to other language will need to be done over the Localizely platform |
OK, better now? |
Can I please get a CI build? |
Do I need to request CI builds on a commit-by-commit basis? |
They don't run automatically for first time contributors. |
How get I get this closer to production? |
Anyone? |
Alex is on vacation and he is one of only a few mobile developers. I don't think there is anything for you to do besides just wait a bit longer unfortunately. |
There is still missing option to sort albums chronologically (dateTimeOriginal). That is most likely option "Most recent photo" - albums with the most recent photos, not most recently edited photos. If a single photo is edited by some graphics app a replaced within an old album, it immediately appers above albums with much newer photos. Please fix that. |
Thanks! |
I've added the "Most recent photo" and "Last modified" options to the album list.
There is a quirk regarding the API which only returns
lastModifiedAssetTimestamp
for/api/albums
, but not/api/albums/:id
. This could be fixed.Since the
lastModifiedAssetTimestamp
is nullable safe comparisons are ...not easy.I'm not a Dart developer by trade but found my way around. If you have any comments, please let me know. I've debugged this through to the best of my knowledge.