Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer the same album sorting options on mobile as on web #3804

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Offer the same album sorting options on mobile as on web #3804

merged 5 commits into from
Oct 12, 2023

Conversation

agross
Copy link
Contributor

@agross agross commented Aug 20, 2023

I've added the "Most recent photo" and "Last modified" options to the album list.

There is a quirk regarding the API which only returns lastModifiedAssetTimestamp for /api/albums, but not /api/albums/:id. This could be fixed.

Since the lastModifiedAssetTimestamp is nullable safe comparisons are ...not easy.

I'm not a Dart developer by trade but found my way around. If you have any comments, please let me know. I've debugged this through to the best of my knowledge.

@vercel
Copy link

vercel bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
immich ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 6:02pm

@alextran1502
Copy link
Contributor

Hello, you only need to add translation key to the EN_US json file, the other files will eventually be autogenerated

@agross
Copy link
Contributor Author

agross commented Aug 21, 2023

@alextran1502 I wasn’t aware of that. Should I change something?

@alextran1502
Copy link
Contributor

You can revert the changes of all the other languages beside the english file

@agross
Copy link
Contributor Author

agross commented Aug 21, 2023

What about this spelling correction (I'm a native German speaker)?

57b4c74

@alextran1502
Copy link
Contributor

The changes to other language will need to be done over the Localizely platform

@agross
Copy link
Contributor Author

agross commented Aug 21, 2023

OK, better now?

@agross
Copy link
Contributor Author

agross commented Aug 26, 2023

Can I please get a CI build?

@agross
Copy link
Contributor Author

agross commented Aug 26, 2023

Do I need to request CI builds on a commit-by-commit basis?

@jrasm91
Copy link
Contributor

jrasm91 commented Aug 26, 2023

They don't run automatically for first time contributors.

@agross
Copy link
Contributor Author

agross commented Sep 2, 2023

How get I get this closer to production?

@agross
Copy link
Contributor Author

agross commented Sep 22, 2023

Anyone?

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 22, 2023

Alex is on vacation and he is one of only a few mobile developers. I don't think there is anything for you to do besides just wait a bit longer unfortunately.

@waclaw66
Copy link
Contributor

waclaw66 commented Oct 9, 2023

There is still missing option to sort albums chronologically (dateTimeOriginal). That is most likely option "Most recent photo" - albums with the most recent photos, not most recently edited photos. If a single photo is edited by some graphics app a replaced within an old album, it immediately appers above albums with much newer photos. Please fix that.

@alextran1502 alextran1502 merged commit e57c926 into immich-app:main Oct 12, 2023
20 checks passed
@agross
Copy link
Contributor Author

agross commented Oct 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants