Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response size metrics #32

Closed
dnlup opened this issue Nov 8, 2021 · 4 comments
Closed

Add response size metrics #32

dnlup opened this issue Nov 8, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request released

Comments

@dnlup
Copy link
Contributor

dnlup commented Nov 8, 2021

I think it might be useful to add a response size metric in the set of stats collected. WDYT?

@simonecorsi
Copy link
Collaborator

Why not request size too? We could have an idea of the network usage with both

@dnlup
Copy link
Contributor Author

dnlup commented Nov 9, 2021

Why not request size too? We could have an idea of the network usage with both

Yes that seems very useful too.

@antoniomuso
Copy link
Contributor

LGTM

@dnlup dnlup added the enhancement New feature or request label Nov 16, 2021
@simonecorsi simonecorsi added this to the 🔥 Version 2 milestone Nov 30, 2021
@dnlup dnlup self-assigned this Feb 22, 2022
simonecorsi added a commit that referenced this issue Mar 2, 2022
simonecorsi added a commit that referenced this issue Mar 3, 2022
simonecorsi added a commit that referenced this issue Mar 4, 2022
simonecorsi added a commit that referenced this issue Mar 7, 2022
simonecorsi added a commit that referenced this issue Mar 8, 2022
simonecorsi added a commit that referenced this issue Mar 8, 2022
simonecorsi pushed a commit that referenced this issue Mar 10, 2022
# [2.0.0](v1.0.0...v2.0.0) (2022-03-10)

### Bug Fixes

* **types:** add missing types ([74444b9](74444b9))
* check for the presence of metrics object ([288771b](288771b)), closes [#134](#134)
* **label:** label with undefined id ([6d79705](6d79705))
* fix isCustomClientCheck ([ff5ffe9](ff5ffe9))
* remove doc decorator ([50abf07](50abf07))
* upgrade fastify-plugin from 3.0.0 to 3.0.1 ([2a04a38](2a04a38))
* **dynamic mode:** fixed this context in getLabel for dynamic mode to be the request context ([0dac171](0dac171))
* **TCP:** fixed tcp ([58690d2](58690d2))
* **types:** added missing type for FastifyContextConfig ([fa07110](fa07110))
* **types:** fix wrong export name ([119fdc3](119fdc3))

### chore

* **deps:** update dats to version 2 ([03d2316](03d2316))

### Features

* add boolean to routes config ([acca747](acca747))
* rename routes.timing in responseTime ([44fe70a](44fe70a))
* **metric:** add req/res size metric ([1f7b2a4](1f7b2a4)), closes [#32](#32)
* added skip for empty ids ([cbee46b](cbee46b))
* allow custom Dats client ([40de470](40de470))
* change configuration object ([df6ba44](df6ba44))
* decorated request and reply with get label function ([f00b9d5](f00b9d5))
* scope instance decorators ([d1331a1](d1331a1))
* **routes:** add normalized strings to context ([4b172d6](4b172d6))
* custom route metric label ([efe0131](efe0131))
* expose process metrics sampler ([67b69c5](67b69c5))
* prerelase ([2d0d1d0](2d0d1d0))

### BREAKING CHANGES

* timing is renamed to responseTime.
* The previous configuration is not supported anymore,
please check your client, routes and health configurations.
* the fastify instance decorators are exported in the `metrics` object.
The `doc` sampler instance is renamed to `sampler`.
* **deps:** there might be breaking changes in the new dats version.
* the routes metrics options have changed.
The default route prefix is now an empty string and not 'api'.
The dats instance is exported as `metricsCLient`.
* **types:** the plugin init functions have different names.
@simonecorsi
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

3 participants