analyze: add support for some unsupported casts #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spernsteiner
force-pushed
the
analyze-unsupported-casts-base
branch
from
5949a50 to
d1e05f3
Compare
spernsteiner
force-pushed
the
analyze-unsupported-casts
branch
from
a5f5566 to
086183a
Compare
aneksteind
reviewed
Jun 6, 2023
aneksteind
approved these changes
Jun 6, 2023
Co-authored-by: Khyber Sen <kkysen@gmail.com>
spernsteiner
force-pushed
the
analyze-unsupported-casts
branch
from
086183a to
1fa5dd0
Compare
spernsteiner
changed the base branch from
analyze-unsupported-casts-base
to
master
|
I rebased this onto I'm not sure if it's worth re-reviewing, since both this and #945 were already approved. @aneksteind, I've re-requested review just in case - feel free to just hit approve if you don't think it's necessary. |
|
The new commits from #936 LGTM. |
|
@spernsteiner consider this re-approval 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds various cases to
emit_cast_desc_descto eliminate all the "unsupported cast" warnings in the current tests, and also changes "unsupported cast" to a panic. In general, "unsupported cast" normally means we're generating code that won't compile (due to type errors), so this is actually a major error for the rewriter.Currently based on #923; I will rebase onto
masteronce that's been merged.