Add hypothetical lifetime to structure rewrites with empty generic type parameter lists #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneksteind
changed the title
aneksteind
force-pushed
the
fix.field.generic
branch
from
33baf48 to
80dce7b
Compare
Deconstructing an HIR field type would fail in the case where there where the field type had no generic parameters, in that it would not be rewritten to include the new hypothetical lifetimes. Now the type is deconstructed correctly by providing an empty generic type parameter list, which allows the hir_args to have the correct value and allows `adt_ty_rw` to run and generate a rewrite for the ADT
aneksteind
force-pushed
the
fix.field.generic
branch
from
80dce7b to
db4819d
Compare
fw-immunant
reviewed
Jun 12, 2023
fw-immunant
approved these changes
Jun 12, 2023
aneksteind
force-pushed
the
fix.field.generic
branch
from
fed2fa4 to
df2376b
Compare
aneksteind
added a commit
that referenced
this pull request
Jun 13, 2023
This was referenced Jun 26, 2023
Merged
aneksteind
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deconstructing an HIR field type would fail in the case where there where the field type had no generic parameters, in that it would not be rewritten to include the new hypothetical lifetimes. Now the type is deconstructed correctly by providing an empty generic type parameter list, which allows the hir_args to have the correct value and allows
adt_ty_rwto run and generate a rewrite for the ADT