-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for emitting casts to and from *mut T and Cell<T> #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The |
That sounds correct to me |
spernsteiner
reviewed
Jul 3, 2023
ca6bf03
to
ec2dbc6
Compare
spernsteiner
reviewed
Jul 5, 2023
spernsteiner
reviewed
Jul 5, 2023
spernsteiner
reviewed
Jul 5, 2023
…wToRef in casting to &Cell
… Borrow adjustment occurs
Co-authored-by: spernsteiner <spernsteiner@galois.com>
5f67f63
to
83979c0
Compare
spernsteiner
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964 . The
lighttpd-minimal
test had failures due to unsupported casts that the rewriter wanted to emit, namely in going to and from*mut T
andCell<T>
. This adds support for those casts via:as_ptr()
rewrite forCell<T>
, which produces the underlying*mut T
*mut T -> *const Cell<T> -> &Cell<T>
rewrite, accomplished through a pointer-to-pointer cast followed by a reborrow&*c
wherec: *const Cell<T>