Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] set lastRepaymentAmount 0 when is null #933

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[bugfix] set lastRepaymentAmount 0 when is null #933

merged 1 commit into from
Sep 28, 2023

Conversation

dev-jotape
Copy link
Collaborator

@dev-jotape dev-jotape commented Sep 27, 2023 •
edited
Loading

This PR fixes #911

Changes

Set lastRepaymentAmount 0 when is null on subgraph_microcredit_borrowers.
The staging and production lambdas have already been updated

Tests

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vibern0 vibern0 merged commit 6d241a3 into main Sep 28, 2023
@vibern0 vibern0 deleted the fix/microcredit-lambda branch September 28, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibern0 vibern0 vibern0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lastRepaymentAmount is NaN to some users in subgraph_microcredit_borrower
2 participants
@dev-jotape @vibern0