[bugfix] fix applications results

[vibern0]

Changes

This PR fixes the response on GET /microcredit/applications so that it includes all the data to be added on the dashboard.

To accommodate that, two new columns were added. The reason behind those two columns was to avoid two LEFT JOINs.

const applications = await models.microCreditApplications.findAndCountAll({
    attributes: ['id', 'amount', 'period', 'status', 'decisionOn', 'createdAt'],
    where,
    include: [
        {
            model: models.appUser,
            as: 'user',
            attributes: ['address', 'firstName', 'lastName', 'avatarMediaPath']
        },
        {
            model: models.microCreditDocs,
            as: 'docs',
            attributes: [],
            // only the document with category type 1 (might not exist)
            where: {
                category: 1
            },
            required: false
        },
        {
            model: models.subgraphMicroCreditBorrowers,
            as: 'borrower',
            attributes: ['claim'],
            required: false
        }
    ],
    order: [[orderKey || 'microCreditApplications.createdAt', orderDirection || 'desc']],
    offset: query.offset,
    limit: query.limit
});

It also changes POST /microcredit/docs, requiring the applicationId.

Tests

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication