Limit role name length

[jsonar-cpapke]

Closes https://onejira.imperva.com/browse/SD-1306

[eytannnaim]

Does this do what you really need?
Shouldn't it be:

name = "${substr(var.name, 0, 64 - 5)}-role"

[lindanasredin]

You need to make this change in DAM and DRA as well to maintain the consistency.

[jsonar-cpapke]

@eytannnaim right, I meant to do length of -role to make it obvious what I was doing, but used the wrong data.

[jsonar-cpapke]

@lindanasredin I thought I only am supposed to manage Sonar code currently. I don't have any way currently to test anything in DAM or DRA.

[lindanasredin]

@jsonar-cpapke You are right basically, except for cases where we need to maintain consistency and it's a simple fix, not a big feature. Surely I don't expect you to test DAM and DRA. When you push the code the actions will test them. Sorry for being presumptuous in my previous message, this is the first time we face such a case and we need to talk about it. So if it's not too much trouble for you, can you please make the change for the other IAM roles? You can search "resource "aws_iam_role"" in the entire project. Actually now that I'm searching, I see there is one more location related to Sonar - the MSSQL.

[jsonar-cpapke]

Can we do that as a separate PR? This is currently preventing on of our QA from testing dsfkit.

[lindanasredin]

It won't matter because we have to release a new version of eDSF Kit for QA to get the fix, and we can't do it with a broken consistency, and we don't release on Thursday and we need to check if we have enough content to make a release.

[jagdeep-sonar]

ok.