Populating additional tags #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
roiklorin
commented
Aug 27, 2024
roiklorin
commented
- added additional tags for poc deployments other than dfs_deployment
- changed additional tags var in the installation deployment directory to match that of dfs_deployment (changed type from list to map)
…and changing additional tags var in the intallation deployment directory to match that of dfs_deployment (changed type to map).
|
Changed target branch to |
lindanasredin
previously approved these changes
Aug 28, 2024
lindanasredin
dismissed
their stale review
Not sure it is correct to use the tags of the older example
lindanasredin
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.