fix: variable undefined turns to internal server error (#441)

implerhq · Dec 19, 2023 · b004f4c · b004f4c
2 parents 6160db5 + 58707de
commit b004f4c
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/apps/api/src/app/shared/services/sandbox/Sandbox.ts b/apps/api/src/app/shared/services/sandbox/Sandbox.ts
@@ -143,18 +143,19 @@ export class Sandbox {
     fs.writeFileSync(standardOutputPath, '');
     fs.writeFileSync(standardErrorPath, '');
 
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
       const process = exec(cmd, async (error, stdout: string | PromiseLike<string>, stderr) => {
+        if (stdout) {
+          fs.appendFileSync(standardOutputPath, await stdout);
+        }
+
         if (error) {
-          reject(error);
+          fs.appendFileSync(standardErrorPath, stderr);
+          resolve({ verdict: EngineResponseStatusEnum.ERROR });
 
           return;
         }
 
-        if (stdout) {
-          fs.appendFileSync(standardOutputPath, await stdout);
-        }
-
         if (stderr) {
           fs.appendFileSync(standardErrorPath, stderr);
         }