-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation Tests #61
Merged
Merged
Validation Tests #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavda-bhavik
commented
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Awesome
chavda-bhavik
added a commit
that referenced
this pull request
Nov 16, 2022
* feat: basic setup * feat: Setup NestJS API * fix: preinstall script not working * feat: Added nx support * fix: start script not running * feat: Added API to create project * fix: swagger response * feat: Added Update API and made DTO reusable * feat: Added Delete project API * fix: Updated module imports * feat: Added Template repository * fix: updated response to return _id * feat: Added setup for templates API with get-templates route * feat: Added create-template API * feat: Added Update template API * feat: Added valid mongodb id validation to params * feat: Added delete API and added error-handling for not-found documents * feat: Added authHeaderName to project * feat: Added shared lib * feat: Added tranformer to tranform code * feat: Added column repository * feat: Added template columns add & fetch routes * feat: Switched create-template API to use projectId from param * feat: Added valid callbackUrl validation * feat: setup localstack and saved sample file to localstack while updating schema * feat: Added Validation for env variables and Added env variable types * feat: Added authentication support * feat: Added file repository * feat: Upload repository * feat: mapping repository * feat: Added file upload API * feat: Completed CSV File Upload API * feat: removed json2csv dependency and build csv by logic * feat: Updated file information on upload * feat: Updated file names to match others * fix: removed comment * fix: Added preinstall scripts to run after instalation to build packages * feat: Removed columnKeys from column and added key and alternateKeys * feat: temp commit * feat: Finalized column mapping * feat: Added Get Headings API * feat: Moved template from body to param for upload * feat: Deleted old validator and updated invalid message for new one * feat: Moved mapping APIs to mapping controller * feat: Finalize Mapping API * feat: Added all-data file to upload and added api to retrive file while review * fix: Updated column data templateId to _templateId * fix: Fix columns not deleting issue * feat: Added Review API * feat: Removed additional properties from schema while processing * feat: wrapped errors in list * fix: Regex pattern validation * fix: Updated fixes and Added validations * feat: refactored and separated file mimetypes from supported types * feat: Added facility to store reviewed data * feat: saved invalid & valid data in files and proceed accordingly * feat: Added stages validation to mapping API * feat: Added field to whether proceed for invalid data or not * feat: Reused get-upload usecase * feat: Added not-found upload validation in mapping * feat: Added confirm review API * Create CODE_OF_CONDUCT.md * feat: Added documentation * Fixed documentation errors Fixed documentation errors * feat: Setup RabbitMQ * feat: Added Storage service to @impler/shared * feat: Implemented Processing functionality for upload file * feat: Put types in seperate file for file-processing * feat: Added webhook-log dal * feat: Added facility to finalize upload * Update README.md "Setup" means system whereas "Set up" is used in the context of setting up a system. Fixed some other documentation errors too. @chavda-bhavik Please review. * feat: Updated recursion flow for processing file * feat: Updated end-review flow to start the process after review is finalized * feat: Added validation error messages * feat: Implemented review API to return data in pagination * feat: Added embed App * feat: Added widget App * feat: Added react package to help import * feat: Added packages * feat: Applied modifications to embed lib * feat: Renamed import-helper package to react * fix: updated embed lint scripts * feat: Organized widget structure * feat: Added widget types and util functions in impler/shared * feat: removed commnt and updated packages * fix: Added missing types for styled-components in @impler/react * feat: Updated docker script and removed unused backendUrl from embed * feat: Updated @impler/react to to be used in packages * feat: Added demo to @impler/react package * feat: Removed default background color and added filter for projectId not defined * feat: Added scripts * feat: Added ReadME for @impler/react demo app * fix: Removed unused dependencies for @impler/embed * feat: Reorganized widget components * feat: Get started with mantine and ModalContainer component * fix: Removed styled-components dependency and used @emotion/react instead * feat: Added Modal and Stepper Design System components with Storybook * feat: Renamed ModalContainer to Modal * feat: Added Button Component * feat: Added gitignore * feat: Added Dropzone component to Design System * feat: Added File component to design system * feat: Added Dropzone component * feat: Added mapping Item component * feat: Added Table component to design system * feat: Added Pagination component to design-system * feat: Added Empty Data Story for Table * feat: Updated Modal and Stepper styles to meet the design needs * feat: Added Select component * feat: Updated select component to meet the design needs * feat: Updated Dropzone, Select and Stepper component styles to meet the design needs * feat: Added required prop and Responsivness to MappingItem * feat: Updated Dropzone and File components to meed design needs: * feat: Removed total data showing from Pagination * feat: Added warning to Table * feat: Added Warning icon and updated config * feat: Added left-icon to Button and added Download icon * feat: Implemented Phases static design * feat: Updated confirmModal flow * feat: Made Modal overlay transparent * feat: Updated dropzone styles and showed file size properly * feat: Updated Phases Modal design and made height to remain same * feat: Updated scrollbar design * feat: Added Complete Step * feat: removed unwanted embed script and streamlined widget open flow * feat: Made ParentCommand Utils reusable * feat: Created separate package @impler/client for API Communication * feat: Added Common API to check if User can access API or not * feat: Updated valid check API to consider ProjectID and Template * feat: Reused access-key names and wrapped axios calls for error handling * feat: Updated layout architecture and Added authentication to Widget * fix: Widget Build issue * feat: Refactored code to reuse EventNames and functionality * feat: Disabled widget logging warning for widget * feat: made start script to start widget and api together * feat: Added Prompt modal * feat: Showed Prompt Modal before Closing and Reseting import * feat: Added error to Dropzone component * feat: Made Widget to load only when show is clicked * feat: Updated select component to be used with ReactHookForm * feat: Added headers support to HttpClient * feat: Added Loading Overlay component * feat: Added Reusable Upload and Template interfaces * feat: Added APIs for UploadFile and GetTemplates * feat: Added Loading Indicators to Footer Buttons * feat: Added Phase1 basic implementation * feat: Implemented Phase1 functionality * fix: Fix issue of first value is always selected in select * fix: Fix isssue of wrong URL creation * feat: Added download sample functionality to widget * feat: Added NoMagicNumber linting * feat: Added commad to build packages before commit * feat: Added notification functionality for download error * fix: Fix issue of Template error not reseting after value changes * feat: Removed building from pre-commit * feat: Made consistency of using PhasesEnum in layout and heading * Implementation Phase 2 (#41) * fix: Issue of Footer actions not comming properly * feat: Added properties to MappingItem to meet development needs * feat: Made updates to App Context, fix warning in svg icon and Added Mapping APIs * feat: Created new component for Phase2 columns heading * feat: Implemented Mapping * feat: Added loading to Phase 2 (#43) * Fix in Upload Again and Reset * feat: Made ReactQuery cache clear on upload reset * feat: Made app to reset progress on close and Upload Again * feat: Updated footer actions * Implementation of Phase 3 & 4 (#46) * feat: Added Review Interface and API * feat: Updated error message formatting * feat: Updated error variable configuration * feat: Showed review data * feat: Implemented Phase3 * feat: Implemented Phase 4 * feat: Added loading indicator in Review * Export Review data (#50) * feat: Added path to shared folder and made invalid data file public * fix: Removed unwanted json2csv types * feat: Added invalidCSVData file parameters to entity * feat: Stored invalid data to csv file while reviewing * feat: Added default page limit and page to review API * feat: Moved Get-Template-Uploads to template controller * feat: Added Get Upload API * feat: Added Export data functionality * feat: fix typo in confirmation with wrong data * fix: Fix storybook run error * fix: Consistency issue among Footer, Title and Stepper * Fix Impler not defined & No Such Bucket errors (#51) * feat: Updated embed import way * fix: Formatted 'impler not defined' error * feat: Made table headings sticky (#53) * Readme Updates & Build workflow (#54) * feat: Added Test Build workflow * feat: Made nestjs available * feat: Optimized and renamed workflow file * feat: Updated version to 0.1.0 * fix: scripts in @impler/client (#55) * Lerna Setup (#56) * fix: Removed unwanted variables from queue-manager env files * feat: Added setup-project-env script * feat: Added learna * v0.1.0 * feat: Added nvmrc * feat: Fix clean & prebuild scripts * Setup widget demo app (#57) * feat: Moved widget-demo to app * feat: Updated env setup script to setup env for widget-demo app * Fixs & Updates (#58) * feat: Made widget to not open window and renamed .env.example to .example.env in widget-demo * refactor: removed unused demo folder from @impler/react * feat: Made widget error more specified * refactor: Organized components hierarchy for better management of state * fix: Removed http-server from embed and added script for starting * fix: Added guards for valid/invalid data not found * feat: Added missing environment variables * feat: Updated number formattion in Confirm and Complete modal * Review phase Updates (#59) * feat: Added missing environment variables ad env-validator to queue-manager * feat: Handled edge case for invalid data not found * Env Updates (#60) * fix: Removed unused env variables * feat: Removed unused start:widget-dev script * feat: Added setup for widget env file * Validation Tests (#61) * test: Added AJVService test cases for isRequired, isEmail and Email types * feat: Added RegExp test cases * test: Added Number test cases * test: Added test cases for Date * test: Added test cases for Select type * test: Added test cases for Any type * fix: Removed unused test scripts and Added test script to test everything * Packages publish updates (#62) * feat: Updated Shared, client, react packages package.json to publish * feat: Updated package.json and added env script for widget * feat: Removed workspace prefix from packages usage Co-authored-by: Rutam Prita Mishra <rutamprita@gmail.com> Co-authored-by: Akash Kundu <112017800+Akash190104@users.noreply.github.com>
chavda-bhavik
added a commit
that referenced
this pull request
Nov 16, 2022
* feat: basic setup * feat: Setup NestJS API * fix: preinstall script not working * feat: Added nx support * fix: start script not running * feat: Added API to create project * fix: swagger response * feat: Added Update API and made DTO reusable * feat: Added Delete project API * fix: Updated module imports * feat: Added Template repository * fix: updated response to return _id * feat: Added setup for templates API with get-templates route * feat: Added create-template API * feat: Added Update template API * feat: Added valid mongodb id validation to params * feat: Added delete API and added error-handling for not-found documents * feat: Added authHeaderName to project * feat: Added shared lib * feat: Added tranformer to tranform code * feat: Added column repository * feat: Added template columns add & fetch routes * feat: Switched create-template API to use projectId from param * feat: Added valid callbackUrl validation * feat: setup localstack and saved sample file to localstack while updating schema * feat: Added Validation for env variables and Added env variable types * feat: Added authentication support * feat: Added file repository * feat: Upload repository * feat: mapping repository * feat: Added file upload API * feat: Completed CSV File Upload API * feat: removed json2csv dependency and build csv by logic * feat: Updated file information on upload * feat: Updated file names to match others * fix: removed comment * fix: Added preinstall scripts to run after instalation to build packages * feat: Removed columnKeys from column and added key and alternateKeys * feat: temp commit * feat: Finalized column mapping * feat: Added Get Headings API * feat: Moved template from body to param for upload * feat: Deleted old validator and updated invalid message for new one * feat: Moved mapping APIs to mapping controller * feat: Finalize Mapping API * feat: Added all-data file to upload and added api to retrive file while review * fix: Updated column data templateId to _templateId * fix: Fix columns not deleting issue * feat: Added Review API * feat: Removed additional properties from schema while processing * feat: wrapped errors in list * fix: Regex pattern validation * fix: Updated fixes and Added validations * feat: refactored and separated file mimetypes from supported types * feat: Added facility to store reviewed data * feat: saved invalid & valid data in files and proceed accordingly * feat: Added stages validation to mapping API * feat: Added field to whether proceed for invalid data or not * feat: Reused get-upload usecase * feat: Added not-found upload validation in mapping * feat: Added confirm review API * Create CODE_OF_CONDUCT.md * feat: Added documentation * Fixed documentation errors Fixed documentation errors * feat: Setup RabbitMQ * feat: Added Storage service to @impler/shared * feat: Implemented Processing functionality for upload file * feat: Put types in seperate file for file-processing * feat: Added webhook-log dal * feat: Added facility to finalize upload * Update README.md "Setup" means system whereas "Set up" is used in the context of setting up a system. Fixed some other documentation errors too. @chavda-bhavik Please review. * feat: Updated recursion flow for processing file * feat: Updated end-review flow to start the process after review is finalized * feat: Added validation error messages * feat: Implemented review API to return data in pagination * feat: Added embed App * feat: Added widget App * feat: Added react package to help import * feat: Added packages * feat: Applied modifications to embed lib * feat: Renamed import-helper package to react * fix: updated embed lint scripts * feat: Organized widget structure * feat: Added widget types and util functions in impler/shared * feat: removed commnt and updated packages * fix: Added missing types for styled-components in @impler/react * feat: Updated docker script and removed unused backendUrl from embed * feat: Updated @impler/react to to be used in packages * feat: Added demo to @impler/react package * feat: Removed default background color and added filter for projectId not defined * feat: Added scripts * feat: Added ReadME for @impler/react demo app * fix: Removed unused dependencies for @impler/embed * feat: Reorganized widget components * feat: Get started with mantine and ModalContainer component * fix: Removed styled-components dependency and used @emotion/react instead * feat: Added Modal and Stepper Design System components with Storybook * feat: Renamed ModalContainer to Modal * feat: Added Button Component * feat: Added gitignore * feat: Added Dropzone component to Design System * feat: Added File component to design system * feat: Added Dropzone component * feat: Added mapping Item component * feat: Added Table component to design system * feat: Added Pagination component to design-system * feat: Added Empty Data Story for Table * feat: Updated Modal and Stepper styles to meet the design needs * feat: Added Select component * feat: Updated select component to meet the design needs * feat: Updated Dropzone, Select and Stepper component styles to meet the design needs * feat: Added required prop and Responsivness to MappingItem * feat: Updated Dropzone and File components to meed design needs: * feat: Removed total data showing from Pagination * feat: Added warning to Table * feat: Added Warning icon and updated config * feat: Added left-icon to Button and added Download icon * feat: Implemented Phases static design * feat: Updated confirmModal flow * feat: Made Modal overlay transparent * feat: Updated dropzone styles and showed file size properly * feat: Updated Phases Modal design and made height to remain same * feat: Updated scrollbar design * feat: Added Complete Step * feat: removed unwanted embed script and streamlined widget open flow * feat: Made ParentCommand Utils reusable * feat: Created separate package @impler/client for API Communication * feat: Added Common API to check if User can access API or not * feat: Updated valid check API to consider ProjectID and Template * feat: Reused access-key names and wrapped axios calls for error handling * feat: Updated layout architecture and Added authentication to Widget * fix: Widget Build issue * feat: Refactored code to reuse EventNames and functionality * feat: Disabled widget logging warning for widget * feat: made start script to start widget and api together * feat: Added Prompt modal * feat: Showed Prompt Modal before Closing and Reseting import * feat: Added error to Dropzone component * feat: Made Widget to load only when show is clicked * feat: Updated select component to be used with ReactHookForm * feat: Added headers support to HttpClient * feat: Added Loading Overlay component * feat: Added Reusable Upload and Template interfaces * feat: Added APIs for UploadFile and GetTemplates * feat: Added Loading Indicators to Footer Buttons * feat: Added Phase1 basic implementation * feat: Implemented Phase1 functionality * fix: Fix issue of first value is always selected in select * fix: Fix isssue of wrong URL creation * feat: Added download sample functionality to widget * feat: Added NoMagicNumber linting * feat: Added commad to build packages before commit * feat: Added notification functionality for download error * fix: Fix issue of Template error not reseting after value changes * feat: Removed building from pre-commit * feat: Made consistency of using PhasesEnum in layout and heading * Implementation Phase 2 (#41) * fix: Issue of Footer actions not comming properly * feat: Added properties to MappingItem to meet development needs * feat: Made updates to App Context, fix warning in svg icon and Added Mapping APIs * feat: Created new component for Phase2 columns heading * feat: Implemented Mapping * feat: Added loading to Phase 2 (#43) * Fix in Upload Again and Reset * feat: Made ReactQuery cache clear on upload reset * feat: Made app to reset progress on close and Upload Again * feat: Updated footer actions * Implementation of Phase 3 & 4 (#46) * feat: Added Review Interface and API * feat: Updated error message formatting * feat: Updated error variable configuration * feat: Showed review data * feat: Implemented Phase3 * feat: Implemented Phase 4 * feat: Added loading indicator in Review * Export Review data (#50) * feat: Added path to shared folder and made invalid data file public * fix: Removed unwanted json2csv types * feat: Added invalidCSVData file parameters to entity * feat: Stored invalid data to csv file while reviewing * feat: Added default page limit and page to review API * feat: Moved Get-Template-Uploads to template controller * feat: Added Get Upload API * feat: Added Export data functionality * feat: fix typo in confirmation with wrong data * fix: Fix storybook run error * fix: Consistency issue among Footer, Title and Stepper * Fix Impler not defined & No Such Bucket errors (#51) * feat: Updated embed import way * fix: Formatted 'impler not defined' error * feat: Made table headings sticky (#53) * Readme Updates & Build workflow (#54) * feat: Added Test Build workflow * feat: Made nestjs available * feat: Optimized and renamed workflow file * feat: Updated version to 0.1.0 * fix: scripts in @impler/client (#55) * Lerna Setup (#56) * fix: Removed unwanted variables from queue-manager env files * feat: Added setup-project-env script * feat: Added learna * v0.1.0 * feat: Added nvmrc * feat: Fix clean & prebuild scripts * Setup widget demo app (#57) * feat: Moved widget-demo to app * feat: Updated env setup script to setup env for widget-demo app * Fixs & Updates (#58) * feat: Made widget to not open window and renamed .env.example to .example.env in widget-demo * refactor: removed unused demo folder from @impler/react * feat: Made widget error more specified * refactor: Organized components hierarchy for better management of state * fix: Removed http-server from embed and added script for starting * fix: Added guards for valid/invalid data not found * feat: Added missing environment variables * feat: Updated number formattion in Confirm and Complete modal * Review phase Updates (#59) * feat: Added missing environment variables ad env-validator to queue-manager * feat: Handled edge case for invalid data not found * Env Updates (#60) * fix: Removed unused env variables * feat: Removed unused start:widget-dev script * feat: Added setup for widget env file * Validation Tests (#61) * test: Added AJVService test cases for isRequired, isEmail and Email types * feat: Added RegExp test cases * test: Added Number test cases * test: Added test cases for Date * test: Added test cases for Select type * test: Added test cases for Any type * fix: Removed unused test scripts and Added test script to test everything * Packages publish updates (#62) * feat: Updated Shared, client, react packages package.json to publish * feat: Updated package.json and added env script for widget * feat: Removed workspace prefix from packages usage * feat: Made impler.io private (#64) Co-authored-by: Rutam Prita Mishra <rutamprita@gmail.com> Co-authored-by: Akash Kundu <112017800+Akash190104@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.