Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark import as 'Completed' after data is sent to frontend #742

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Sidd-77
Copy link
Contributor

@Sidd-77 Sidd-77 commented Aug 11, 2024

BUG #730

Fix Import Status Not Updating to 'Completed' After Data Sent to Frontend

Issue:

  • The import status was incorrectly remaining as "Processing" even after the data was successfully sent to the frontend application.

Solution:

  • Updated the logic to ensure that once the data import is completed and sent to the frontend, the import status is properly marked as "Completed."

Steps to Reproduce:

  1. Create or update an import with the destination set to Frontend.
  2. Complete the import process and close the import widget.
  3. Check the import log in the Analytics section; it incorrectly shows the status as "Processing."

Expected Behavior:

  • The import status should be updated to "Completed" once the data is sent to the frontend.

Changes Made:

  • Modified the import status update logic to correctly reflect the completed status for imports directed to the frontend.

Testing:

  • Verified that the status now changes to "Completed" after the import is sent to the frontend as expected.

@chavda-bhavik
Copy link
Member

Awesome contribution @Sidd-77

Copy link

nx-cloud bot commented Aug 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eab6308. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@chavda-bhavik chavda-bhavik merged commit f8cbfe0 into implerhq:next Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend destination imports should be marked as Completed once data is sent
2 participants