Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for MinIO object store, fixed CONTRIBUTING.md and setup script #752

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

Sidd-77
Copy link
Contributor

@Sidd-77 Sidd-77 commented Aug 15, 2024

Description

  • Issue Fix: Resolved issue Suppoeting Minio object storage for self hosting Impler #743 by adding support for Minio object storage, enabling self-hosting for Impler.
  • Documentation Update: Revised CONTRIUTING.md to reflect the latest guidelines and processes.
  • Setup Script Fix: Updated and corrected the setup script to ensure a correct setup of the web part.

Details

  • Integrated Minio as an alternative object storage solution for those who prefer or require self-hosting options. Adjusted the configuration and ensured compatibility with existing workflows.
  • Made several improvements to the CONTRIBUTING.md file, including clearer instructions and updated requirements, making it easier for new contributors to get started.
  • Fixed issues in the setup script that were causing errors during initial setup. This should improve the setup experience and reduce friction for new developers.

Testing

  • Verified that Minio integrates seamlessly with the existing setup and that all relevant functionalities are working as expected.
  • Tested the revised setup script on multiple environments to ensure consistent and error-free setup.
  • Reviewed the updated CONTRIBUTING.md with a new contributor to ensure clarity and completeness.

Resolves #743

Copy link

nx-cloud bot commented Aug 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit aec818f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Sidd-77 Sidd-77 changed the title feat: added support for MinIO object store, fixed CONTRIBUTIN.md and setup script feat: added support for MinIO object store, fixed CONTRIBUTING.md and setup script Aug 15, 2024
@chavda-bhavik chavda-bhavik self-requested a review August 16, 2024 04:16
Copy link
Member

@chavda-bhavik chavda-bhavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidd-77 You're contribution is awesome. Added two comments, please have a look.

I'm very excited to make it live.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Siddharth Salunkhe <102907405+Sidd-77@users.noreply.github.com>
@chavda-bhavik chavda-bhavik merged commit 4aa5f65 into implerhq:next Aug 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppoeting Minio object storage for self hosting Impler
2 participants