-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency synckit
to ^0.8.3 for yarn PnP
#169
chore(deps): update dependency synckit
to ^0.8.3 for yarn PnP
#169
Conversation
|
ce875a3
to
4faa186
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
You can upgrade |
How can i upgrade |
|
I am testing in the Yarn Berry Monorepo environment. yarnPath: .yarn/releases/yarn-3.2.1.cjs
packageExtensions:
'eslint-import-resolver-typescript@^3.4.0':
dependencies:
synckit: '^0.8.3' Isn't it impossible to use it in Yarn PnP environment unless you upgrade it manually? |
I tried in https://github.com/kriasoft/react-starter-kit, it seems true, so this PR is accepted. In my imagine, when I remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
synckit
to ^0.8.3 for yarn PnP
@hanseo0507 Thanks for your contribution! |
@JounQin Thank you for reviewing my PR. |
Right now. |
Okay. Thank you! |
|
For future reference, if using Yarn Modern, you can update a transitive dependency like synckit by running |
I updated dependency sycnkit to from
^0.8.1
to^0.8.3
.This is because synckit@^0.8.1 breaks using this pugin with Yarn PnP in VSCode.
This issue has already been reported(#164), and has been resolved in synckit(un-ts/synckit#98), but this plugin dependency has not been updated